Bugzilla – Attachment 176253 Details for
Bug 38751
Creating ILL request through OPAC openURL explodes if same attribute defined twice
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38751: Update Standard ILL backend migrate
Bug-38751-Update-Standard-ILL-backend-migrate.patch (text/plain), 2.51 KB, created by
Martin Renvoize (ashimema)
on 2025-01-08 16:13:32 UTC
(
hide
)
Description:
Bug 38751: Update Standard ILL backend migrate
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-01-08 16:13:32 UTC
Size:
2.51 KB
patch
obsolete
>From deec7b14ac3f0edcbe0752fca6c8e9bbc458be84 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 3 Jan 2025 12:15:47 -0100 >Subject: [PATCH] Bug 38751: Update Standard ILL backend migrate > >Make use of newly updated ILL::Request->extended_attributes method instead of creating the query manually > >The test plan in bug 38819 fails without this patch (page explodes with duplicate ID error). >It's the same cause as the one being fixed here in bug 38751 so I'm submitting this here. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/ILL/Backend/Standard.pm | 30 +++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > >diff --git a/Koha/ILL/Backend/Standard.pm b/Koha/ILL/Backend/Standard.pm >index d3ed496f7f4..fbfef9bc52e 100644 >--- a/Koha/ILL/Backend/Standard.pm >+++ b/Koha/ILL/Backend/Standard.pm >@@ -698,19 +698,19 @@ sub migrate { > my $original_attributes = > $original_request->extended_attributes->search( { type => { '-in' => \@default_attributes } } ); > >- my $request_details = >- { map { $_->type => $_->value } ( $original_attributes->as_list ) }; >- $request_details->{migrated_from} = $original_request->illrequest_id; >- while ( my ( $type, $value ) = each %{$request_details} ) { >- Koha::ILL::Request::Attribute->new( >- { >- illrequest_id => $new_request->illrequest_id, >- column_exists( 'illrequestattributes', 'backend' ) ? ( backend => "Standard" ) : (), >- type => $type, >- value => $value, >- } >- )->store; >- } >+ my @request_details_array = map { >+ { >+ 'type' => $_->type, >+ 'value' => $_->value, >+ } >+ } $original_attributes->as_list; >+ >+ push @request_details_array, { >+ 'type' => 'migrated_from', >+ 'value' => $original_request->illrequest_id, >+ }; >+ >+ $new_request->extended_attributes( \@request_details_array ); > > return { > error => 0, >@@ -993,8 +993,8 @@ sub add_request { > > my @request_details_array = map { > { >- 'type' => $_, >- 'value' => $request_details->{$_}, >+ 'type' => $_, >+ 'value' => $request_details->{$_}, > } > } keys %{$request_details}; > $request->extended_attributes( \@request_details_array ); >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38751
:
175700
|
175701
|
175702
|
175703
|
175704
|
175705
|
175903
|
175904
|
175905
|
176124
|
176250
|
176251
|
176252
| 176253