Bugzilla – Attachment 176283 Details for
Bug 38845
OpacNoItemTypeImages required to show item type images in staff interface advanced search
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search
Bug-38845-OpacNoItemTypeImages-required-to-show-it.patch (text/plain), 2.53 KB, created by
David Nind
on 2025-01-09 08:07:37 UTC
(
hide
)
Description:
Bug 38845: OpacNoItemTypeImages required to show item type images in staff interface advanced search
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-01-09 08:07:37 UTC
Size:
2.53 KB
patch
obsolete
>From dbaa956ca004c8a1f36c1b82a9f03bb3e152c077 Mon Sep 17 00:00:00 2001 >From: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Date: Tue, 7 Jan 2025 16:50:05 -0500 >Subject: [PATCH] Bug 38845: OpacNoItemTypeImages required to show item type > images in staff interface advanced search > >This patch makes it so that the noItemTypeImages system preference is >the one that controls the display of item type images in the staff >interface advanced search page. It was previously erroneously managed by >the OpacNoItemTypeImages system preference. > >To test: > >1. Add images to item types, if there aren't any already (KTD has them by default) > 1.1. Go to Administration > Item types > 1.2. Click 'Edit' next to one of the item types > 1.3. Choose an icon > 1.4. Click 'Save changes' > >2. Disable OpacNoItemTypeImages > >3. Enable noItemTypeImages (already enabled in KTD) > >4. Go to the advanced search page > --> The item types don't have any images next to them > >5. Apply patch and refresh the page > --> The item type images should be displayed > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >index 9e5562ae64..c7a28baf78 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt >@@ -244,7 +244,7 @@ > <input type="checkbox" id="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]" name="limit" value="mc-[% itemtypeloo.ccl | html %]:[% itemtypeloo.code | html %]"/> > [% END # /IF limits.$limit_key.defined %] > <label for="[% itemtypeloo.ccl FILTER remove(',') | html %]-[% itemtypeloo.number | html %]"> >- [% UNLESS ( Koha.Preference('OpacNoItemTypeImages') ) %] >+ [% UNLESS ( Koha.Preference('noItemTypeImages') ) %] > [% IF ( itemtypeloo.imageurl ) %] > <img class="itemtype-image" src="[% itemtypeloo.imageurl | html %]" alt="[% itemtypeloo.description | html %]" /> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38845
:
176211
|
176283
|
176316