Bugzilla – Attachment 176301 Details for
Bug 11530
Recalculating an item's total issue count with update_totalissues.pl ignores deleted items
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11530: Fix warning of undefined value
Bug-11530-Fix-warning-of-undefined-value.patch (text/plain), 787 bytes, created by
David Nind
on 2025-01-09 20:07:35 UTC
(
hide
)
Description:
Bug 11530: Fix warning of undefined value
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-01-09 20:07:35 UTC
Size:
787 bytes
patch
obsolete
>From 70ac0ea882aeffcf25fb0b7e401e8539be7ac1b9 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Sat, 21 Dec 2024 12:58:35 +0000 >Subject: [PATCH] Bug 11530: Fix warning of undefined value > >We always check the return of UpdateTotalIssues, we shouldn't let it return null > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Biblio.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 6f36813c98..1018644c77 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -3075,7 +3075,7 @@ sub UpdateTotalIssues { > my $biblio = Koha::Biblios->find($biblionumber); > unless ($biblio) { > carp "UpdateTotalIssues could not get biblio"; >- return; >+ return -1; > } > > my $record; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11530
:
175880
|
175881
|
176300
| 176301 |
177523