Bugzilla – Attachment 176338 Details for
Bug 38832
Dead code in catalogue/search.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38832: (QA follow-up) Remove unused $page variables
Bug-38832-QA-follow-up-Remove-unused-page-variable.patch (text/plain), 1.36 KB, created by
Pedro Amorim
on 2025-01-10 14:25:38 UTC
(
hide
)
Description:
Bug 38832: (QA follow-up) Remove unused $page variables
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-01-10 14:25:38 UTC
Size:
1.36 KB
patch
obsolete
>From 4a0a8ab0a4c64d3d489e6a363e262a3d9c405b86 Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 6 Jan 2025 23:39:25 +0000 >Subject: [PATCH] Bug 38832: (QA follow-up) Remove unused $page variables > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > catalogue/search.pl | 3 --- > 1 file changed, 3 deletions(-) > >diff --git a/catalogue/search.pl b/catalogue/search.pl >index 7ce2edf0b55..d616dc1141f 100755 >--- a/catalogue/search.pl >+++ b/catalogue/search.pl >@@ -433,8 +433,6 @@ my $offset = $params->{'offset'} || 0; > my $whole_record = $params->{'whole_record'} || 0; > my $weight_search = $params->{'advsearch'} ? $params->{'weight_search'} || 0 : 1; > $offset = 0 if $offset < 0; >-my $page = $cgi->param('page') || 1; >-#my $offset = ($page-1)*$results_per_page; > > # Define some global variables > my ( $error,$query,$simple_query,$query_cgi,$query_desc,$limit,$limit_cgi,$limit_desc,$query_type); >@@ -561,7 +559,6 @@ if ($@ || $error) { > $hits = $quoted_hits; > } > } >- my $page = $cgi->param('page') || 0; > my @newresults = searchResults({ 'interface' => 'intranet' }, $query_desc, $hits, $results_per_page, $offset, $scan, > $results_hashref->{$server}->{"RECORDS"}); > $total = $total + $hits; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38832
:
176151
|
176152
|
176167
|
176168
|
176169
|
176336
|
176337
| 176338