Bugzilla – Attachment 176363 Details for
Bug 26553
Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC
Bug-26553-Remove-useless-INCLUDE-of-columnssetting.patch (text/plain), 4.31 KB, created by
Lucas Gass (lukeg)
on 2025-01-10 14:55:26 UTC
(
hide
)
Description:
Bug 26553: Remove useless INCLUDE of columns_settings.inc - OPAC
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-01-10 14:55:26 UTC
Size:
4.31 KB
patch
obsolete
>From a5f8aaf5b8c7f4990e0cf421da50f83bb18a4217 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 2 Dec 2024 12:36:54 +0100 >Subject: [PATCH] Bug 26553: Remove useless INCLUDE of columns_settings.inc - > OPAC > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt | 1 - > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 1 - > 6 files changed, 6 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >index 4300a1ebb70..4aa0f926cd6 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt >@@ -122,7 +122,6 @@ > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >- [% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { > table_settings = [% TablesSettings.GetTableSettings( 'opac', 'course_items', 'course-items-table', 'json' ) | $raw %]; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >index d701e521ec5..7d17f989136 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-reserves.tt >@@ -71,7 +71,6 @@ > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >- [% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { > table_settings = [% TablesSettings.GetTableSettings( 'opac', 'course_list', 'course_reserves_table', 'json' ) | $raw %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 9bca3319d8e..ce539017735 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1442,7 +1442,6 @@ > [% Asset.js("js/modals/catalog_concern.js") | $raw %] > [% END %] > [% INCLUDE 'datatables.inc' %] >- [% INCLUDE 'columns_settings.inc' %] > [% INCLUDE greybox.inc %] > [% IF ( OpacStarRatings != 'disable' ) %] > [% Asset.js("lib/jquery/plugins/jquery.barrating.min.js") | $raw %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt >index 1eb0597e29d..6390c81b8f7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-holdshistory.tt >@@ -179,7 +179,6 @@ > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >-[% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { > $('#sort').change(function() { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >index 9d8c6d6116c..258f8599ab8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt >@@ -223,7 +223,6 @@ > [% INCLUDE 'opac-bottom.inc' %] > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >-[% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function(){ > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index 9bb6cb09d19..35bc1b4581d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -289,7 +289,6 @@ > > [% BLOCK jsinclude %] > [% INCLUDE 'datatables.inc' %] >-[% INCLUDE 'columns_settings.inc' %] > <script> > $(document).ready(function() { > // We show table ordered by descending dates by default >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26553
:
175186
|
175187
|
175188
|
175189
|
175190
|
175191
|
175874
|
175875
|
175876
|
175877
|
175878
|
175879
|
176359
|
176360
|
176361
|
176362
|
176363
|
176364
|
176588
|
176589
|
176590
|
176591
|
177087
|
177088
|
177089
|
177090
|
177091
|
177092
|
177152
|
177153
|
177154
|
177155
|
177156
|
177157
|
177158
|
177234
|
177235
|
177236
|
177237
|
177238
|
177239
|
177240
|
177241
|
177242
|
177243
|
177246
|
177247
|
177264
|
177265
|
177271
|
177888
|
177889
|
177890
|
177891
|
177892
|
177893
|
177894
|
177895
|
177896
|
177897
|
177898
|
177899
|
177900
|
178508
|
178509
|
178510
|
178511
|
178512
|
178513
|
178514
|
178515
|
178516
|
178517
|
178518
|
178519
|
178520
|
178521
|
178522
|
178523
|
178524
|
178525
|
178526
|
178527
|
178528
|
178529
|
178530
|
178531
|
178532
|
178533