Bugzilla – Attachment 176404 Details for
Bug 38793
Transfer silently not canceled when TransfersBlockCirc = "don't block" and AutomaticConfirmTransfer = "do automatically confirm"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38793: Don't dismiss modal before submitting form
Bug-38793-Dont-dismiss-modal-before-submitting-for.patch (text/plain), 3.04 KB, created by
Victor Grousset/tuxayo
on 2025-01-11 00:15:47 UTC
(
hide
)
Description:
Bug 38793: Don't dismiss modal before submitting form
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2025-01-11 00:15:47 UTC
Size:
3.04 KB
patch
obsolete
>From 2c69c3c857b51b036f4456571c6dee5ba041c836 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Tue, 7 Jan 2025 08:37:48 -0500 >Subject: [PATCH] Bug 38793: Don't dismiss modal before submitting form > >Remove the bs-data-dismiss attribute from the "cancel transfer" button >on the Wrong Transfer modal. The "cancel transfer" button's JS works by >adding a hidden input and then submitting the form - we don't want >Bootstrap to dismiss the modal before the embedded form has been >submitted. > >Note: This bug seems to be browser-dependent. So far it has been >reproduced with Firefox, but not Chrome/Chromium or Microsoft Edge > >To test: >1. Log into the staff client using Firefox >2. Set up system preferences: > TransfersBlockCirc - Don't block > AutomaticConfirmTransfer - Do >3. Find or create an item that belongs to a branch other than the > logged-in branch >4. Check in the item to trigger a Return to Home transfer >5. Click OK on the modal to confirm the transfer >6. Check in the item again to trigger a Wrong Transfer modal >7. Click the "Cancel transfer" button on the modal >8. Navigate to the bib for that item and check the item status >--> The transfer wasn't cancelled - the item is still in transit >9. Apply patch and refresh the page >10. Repeat steps 6-8 >--> Item shows as available - the transfer was cancelled successfully > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 37dfd570b1..831fccc11b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -616,7 +616,7 @@ > <!-- PRINT SLIP --> > <button type="button" data-bs-dismiss="modal" class="btn btn-default submit openWin" data-transfer="[% NewTransfer | html %]" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&&branchcode=[% TransferWaitingAt | uri %]&op=slip" accesskey="p"><i class="fa fa-print"></i> Print transfer slip (P)</button> > <!-- CANCEL TRANSFER --> >- <button type="button" data-bs-dismiss="modal" class="btn btn-default deny cancel" accesskey="x"><i class="fa fa-times"></i> Cancel transfer (X)</button> >+ <button type="button" class="btn btn-default deny cancel" accesskey="x"><i class="fa fa-times"></i> Cancel transfer (X)</button> > </div> <!-- /.modal-footer --> > </form> <!-- /wrongtransferform --> > </div> <!-- /.modal-content --> >-- >2.47.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38793
:
176189
|
176368
|
176387
| 176404