Attachment 17641 Details for Bug 9219 – [PASSED QA] Bug 9219 - Show damaged and lost statuses for issues on circulation.pl as they are on moremember.pl

[patch] [PASSED QA] Bug 9219 - Show damaged and lost statuses for issues on circulation.pl as they are on moremember.pl

PASSED-QA-Bug-9219---Show-damaged-and-lost-statuse.patch (text/plain), 5.26 KB, created by Katrin Fischer on 2013-04-24 05:28:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2013-04-24 05:28:37 UTC

Size: 5.26 KB

patch

obsolete

>From b5a6c4180fb1fe9f0232dce0afe64a26d78e0a28 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 5 Dec 2012 13:55:00 -0500
>Subject: [PATCH] [PASSED QA] Bug 9219 - Show damaged and lost statuses for
> issues on circulation.pl as they are on moremember.pl
>
>This patch adds the lost and damaged status for an issued item to the
>table of issued items on circulation.pl to make it align more closely to
>the same table on moremember.pl
>
>Test Plan:
>1) Apply patch
>2) Issue an item
>3) Set the item's damaged status
>4) Verify the status is showing near the date due on circulation.pl
>5) Clear the damaged status and set the lost status again
>6) Repeat step 4
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>http://bugs.koha-community.org/show_bug.cgi?id=6739
>Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
>I could only test this with the DAMAGED value, because
>currently lost items are removed from the patron account
>when you set the status.
>I know there is a patch somewhere
>to make it optional and the change looks alright.
>Passes all tests and QA script.
>---
> .../prog/en/modules/circ/circulation.tt | 22 ++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index b7f7c4c..05dbefa 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -819,6 +819,13 @@ No patron matched [% message %]
> [% END %]
> [% IF ( todayissue.od ) %]<td class="od">[% ELSE %]<td>[% END %]
> [% todayissue.dd %]
>+
>+ [% IF ( todayissue.itemlost ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'LOST', todayissue.itemlost ) %]
>+ [% END %]
>+ [% IF ( todayissue.damaged ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'DAMAGED', todayissue.damaged ) %]
>+ [% END %]
> </td>
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% todayissue.biblionumber %]&amp;type=intra">[% todayissue.title |html %]</a>[% IF ( todayissue.author ) %], by [% todayissue.author %][% END %][% IF ( todayissue.itemnotes ) %]- [% todayissue.itemnotes %][% END %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% todayissue.biblionumber %]&amp;itemnumber=[% todayissue.itemnumber %]#item[% todayissue.itemnumber %]">[% todayissue.barcode %]</a></td>
> <td>[% UNLESS ( noItemTypeImages ) %] [% IF ( todayissue.itemtype_image ) %]<img src="[% todayissue.itemtype_image %]" alt="" />[% END %][% END %][% todayissue.itemtype %]</td>
>@@ -899,6 +906,13 @@ No patron matched [% message %]
> [% END %]
> [% IF ( previssue.od ) %]<td class="od">[% ELSE %]<td>[% END %]
> [% previssue.dd %]
>+
>+ [% IF ( previssue.itemlost ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'LOST', previssue.itemlost ) %]
>+ [% END %]
>+ [% IF ( previssue.damaged ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'DAMAGED', previssue.damaged ) %]
>+ [% END %]
> </td>
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% previssue.biblionumber %]&amp;type=intra">[% previssue.title |html %]</a>[% IF ( previssue.author ) %], by [% previssue.author %][% END %] [% IF ( previssue.itemnotes ) %]- [% previssue.itemnotes %][% END %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% previssue.biblionumber %]&amp;itemnumber=[% previssue.itemnumber %]#item[% previssue.itemnumber %]">[% previssue.barcode %]</a></td>
> <td>
>@@ -1030,6 +1044,14 @@ No patron matched [% message %]
> [% END %]
> [% IF ( relissue.overdue ) %]<td class="od">[% ELSE %]<td>[% END %]
> [% relissue.dd %]</td>
>+
>+ [% IF ( relissue.itemlost ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'LOST', relissue.itemlost ) %]
>+ [% END %]
>+ [% IF ( relissue.damaged ) %]
>+ [% KohaAuthorisedValues.GetByCode( 'DAMAGED', relissue.damaged ) %]
>+ [% END %]
>+ </td>
> <td><a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% relissue.biblionumber %]&amp;type=intra">[% relissue.title |html %]</a>[% IF ( relissue.author ) %], by [% relissue.author %][% END %][% IF ( relissue.itemnotes ) %]- [% relissue.itemnotes %][% END %] <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% relissue.biblionumber %]&amp;itemnumber=[% relissue.itemnumber %]#item[% relissue.itemnumber %]">[% relissue.barcode %]</a></td>
> <td>[% UNLESS ( noItemTypeImages ) %] [% IF ( relissue.itemtype_image ) %]<img src="[% relissue.itemtype_image %]" alt="" />[% END %][% END %][% relissue.itemtype %]</td>
> <td>[% relissue.displaydate %]</td>
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 9219: 13898 | 15255 | 15256 | 16124 | 17621 | 17641