Bugzilla – Attachment 176480 Details for
Bug 37334
Cannot filter holdings table by status
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37334: Add filter_by_recall test
Bug-37334-Add-filterbyrecall-test.patch (text/plain), 1.72 KB, created by
Lucas Gass (lukeg)
on 2025-01-13 22:37:41 UTC
(
hide
)
Description:
Bug 37334: Add filter_by_recall test
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-01-13 22:37:41 UTC
Size:
1.72 KB
patch
obsolete
>From 2ca41ee33df7c1edd09b660ec9357e04500e3cac Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 13 Jan 2025 22:37:19 +0000 >Subject: [PATCH] Bug 37334: Add filter_by_recall test > >--- > t/db_dependent/Koha/Items.t | 32 +++++++++++++++++++++++++++++++- > 1 file changed, 31 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Items.t b/t/db_dependent/Koha/Items.t >index 7a2d3b7868f..79f9ada2229 100755 >--- a/t/db_dependent/Koha/Items.t >+++ b/t/db_dependent/Koha/Items.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 24; >+use Test::More tests => 25; > > use Test::MockModule; > use Test::Exception; >@@ -2380,3 +2380,33 @@ subtest 'filter_by_in_bundle' => sub { > $schema->storage->txn_rollback; > > }; >+ >+subtest 'filter_by_has_recalls' => sub { >+ plan tests => 2; >+ >+ $schema->storage->txn_begin; >+ >+ my $library = $builder->build_object( { class => 'Koha::Libraries' } ); >+ >+ $biblio = $builder->build_sample_biblio( { author => 'Hall, Daria' } ); >+ my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); >+ t::lib::Mocks::mock_userenv( { branchcode => $patron->branchcode } ); >+ >+ my $item = $builder->build_sample_item( >+ { >+ biblionumber => $biblio->biblionumber, >+ library => $library->branchcode, >+ } >+ ); >+ >+ C4::Circulation::AddIssue( $patron, $item->barcode ); >+ >+ is( $biblio->items->filter_by_has_recalls->count, 0, "0 items with recalls on this record" ); >+ >+ Koha::Recalls->add_recall( { biblio => $item->biblio, item => $item, patron => $patron } ); >+ >+ is( $biblio->items->filter_by_has_recalls->count, 1, "1 item with recalls on this record" ); >+ >+ $schema->storage->txn_rollback; >+ >+}; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37334
:
172300
|
172301
|
172302
|
173499
|
173500
|
173501
|
173949
|
173950
|
173951
|
173982
|
174310
|
174798
|
174799
|
174800
|
174801
|
174802
|
174803
|
174804
|
174813
|
174814
|
174901
|
174902
|
174903
|
174955
|
175859
|
175860
|
175861
|
175862
|
175863
|
175864
|
175865
|
175866
|
175867
|
175868
|
175869
|
175870
|
175871
|
175999
|
176000
|
176001
|
176002
|
176003
|
176004
|
176005
|
176006
|
176007
|
176008
|
176009
|
176010
|
176011
|
176023
|
176024
|
176025
|
176026
|
176027
|
176028
|
176029
|
176030
|
176031
|
176032
|
176033
|
176034
|
176035
|
176475
|
176477
|
176480
|
176481
|
177321
|
177415
|
177416
|
177417
|
177418
|
177419
|
177420
|
177421
|
177422
|
177423
|
177424
|
177425
|
177426
|
177427
|
177428
|
177429
|
177430
|
177431
|
177432