Bugzilla – Attachment 176496 Details for
Bug 38776
Propose a list of value for restriction comment
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments
Bug-38776-new-RCOMMENTS-authorized-value-category-.patch (text/plain), 3.47 KB, created by
ByWater Sandboxes
on 2025-01-14 10:43:44 UTC
(
hide
)
Description:
Bug 38776: new "R_COMMENTS" authorized value category for manual restrictions comments
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2025-01-14 10:43:44 UTC
Size:
3.47 KB
patch
obsolete
>From d37c7a5e6e2a4a06949e941b99440adc190a9e9e Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Mon, 23 Dec 2024 16:25:26 +0100 >Subject: [PATCH] Bug 38776: new "R_COMMENTS" authorized value category for > manual restrictions comments >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Test plan : >- on a patron page, add a manual restriction and fill in a comment, that needs to be typed-in >- apply patch >- create a new authorized value category named "R_COMMENTS" and create a couple of values with a description >- return to patron page and when adding a manual restriction, on click on the input field you would be proposed the authorized values descriptions. >- also you can inspect the code and see that there is a datalist element containing the list of options. > >Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> >--- > .../prog/en/includes/patron-restrictions-tab.inc | 11 ++++++++++- > .../prog/en/modules/admin/authorised_values.tt | 4 +++- > 2 files changed, 13 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >index d1a4a64ccd..aadf9f5beb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-restrictions-tab.inc >@@ -80,7 +80,16 @@ > </select> > </li> > [% END %] >- <li><label for="rcomment">Comment:</label> <input type="text" id="rcomment" name="comment" /></li> >+ <li> >+ <label for="rcomment">Comment:</label> >+ <input type="text" id="rcomment" list="rcomments" name="comment"/> >+ <datalist id="rcomments"> >+ [% FOREACH rcomment IN AuthorisedValues.Get( 'R_COMMENTS' ) %] >+ <option value="[% rcomment.lib | html %]">[% rcomment.lib | html %]</option> >+ [% END %] >+ </datalist> >+ <input type="submit"> >+ </li> > <li> > <label for="rexpiration">Expiration:</label> > <input name="expiration" id="rexpiration" size="20" value="" class="flatpickr" data-flatpickr-futuredate="true" type="text" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >index b25ac29e6a..9dd5f46a4b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt >@@ -542,7 +542,9 @@ > [% CASE 'REPORT_SUBGROUP' %] > <p>Can be used to further sort and filter your reports. This category is empty by default. Values here need to include the authorized value code from REPORT_GROUP in the Description (OPAC) field to link the subgroup to the appropriate group.</p> > [% CASE 'RESTRICTED' %] >- <p>Restricted status of an item</p> >+ <p>Restricted status of an item</p> >+ [% CASE 'R_COMMENTS' %] >+ <p>Values for custom patron restriction comments to pre-fill the manual restrictions. The value in the description field should be the message text and is limited to 200 characters</p> > [% CASE 'ROADTYPE' %] > <p>Road types to be used in patron addresses</p> > [% CASE 'SIP_MEDIA_TYPE' %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38776
:
175912
|
176160
|
176493
| 176496 |
176497
|
176498