Bugzilla – Attachment 176516 Details for
Bug 37546
We should output error messages alongside error codes for z39.50 errors
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37546: Error message output improvements
Bug-37546-Error-message-output-improvements.patch (text/plain), 2.03 KB, created by
Lucas Gass (lukeg)
on 2025-01-14 16:44:14 UTC
(
hide
)
Description:
Bug 37546: Error message output improvements
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-01-14 16:44:14 UTC
Size:
2.03 KB
patch
obsolete
>From b79e5a52445e539e1728b5e29b34042265ff30f2 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 13 Jan 2025 07:50:00 +0000 >Subject: [PATCH] Bug 37546: Error message output improvements > >As suggested by David, I've re-arranged the message output so we pass >'message' first, followed by the error reference inside brackets, >followed by "for SERVER" and finally "result No." > >This follows the Z39.50 suggestions more closely whilst still including >our level of detail for Server + Result number. > >Signed-off-by: David Cook <dcook@prosentient.com.au> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 8be7fba1943..ebd775da043 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -123,7 +123,7 @@ > [% IF ( errcon.error == '10000' ) %]<li>Connection failed to [% errcon.server | html %]</li> > [% ELSIF ( errcon.error == '10007' ) %]<li>Connection timeout to [% errcon.server | html %]</li> > [% ELSIF errcon.error.match( '^XSLTH' ) %]<li>[% errcon.server | html %] record [% errcon.seq | html %]: [% PROCESS 'xslt-handler.inc' code=errcon.error %]</li> >- [% ELSE %]<li>[% errcon.server | html %] record [% errcon.seq | html %]: [% errcon.error | html %] - [% errcon.error_msg | html %]</li> >+ [% ELSE %]<li>[% errcon.error_msg | html %] (ref. [% errcon.error | html %]) for [% errcon.server | html %] result [% errcon.seq | html %]</li> > [% END %] > [% END %] > </ul> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37546
:
169953
|
176422
|
176423
|
176424
|
176482
|
176483
|
176515
| 176516