Bugzilla – Attachment 176634 Details for
Bug 38149
Make ESLint config compatible with version 9 and have ESLint and Prettier installed by default
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38149: Make ESLint config compatible with version 9
Bug-38149-Make-ESLint-config-compatible-with-versi.patch (text/plain), 1.52 KB, created by
Jonathan Druart
on 2025-01-16 11:22:51 UTC
(
hide
)
Description:
Bug 38149: Make ESLint config compatible with version 9
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-01-16 11:22:51 UTC
Size:
1.52 KB
patch
obsolete
>From 852dd308d23995e3b2936af5a4bd9ab3e91c624f Mon Sep 17 00:00:00 2001 >From: Victor Grousset/tuxayo <victor@tuxayo.net> >Date: Fri, 11 Oct 2024 04:01:04 +0200 >Subject: [PATCH] Bug 38149: Make ESLint config compatible with version 9 > >Test plan >1. Apply patch >2. Start KTD (to check that stuff is installed automatically) >3. Run this: > ESLINT_USE_FLAT_CONFIG='false' eslint koha-tmpl/intranet-tmpl/prog/js/ajax.js >4. You should see errors from prettier in addition to others > >QA notes: >1. Run this: > yarn why eslint; yarn why prettier; yarn why eslint-config-prettier; yarn why eslint-plugin-prettier >2. See that the version are the latest from NPM website >3. See that they are in devDependencies > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .eslintrc.json | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > >diff --git a/.eslintrc.json b/.eslintrc.json >index e6bb78fb4ce..e7f78af690f 100644 >--- a/.eslintrc.json >+++ b/.eslintrc.json >@@ -5,7 +5,10 @@ > }, > "extends": [ > "eslint:recommended", >- "prettier" >+ "eslint-config-prettier" >+ ], >+ "plugins": [ >+ "eslint-plugin-prettier" > ], > "rules": { > "indent": [ >@@ -19,7 +22,9 @@ > "semi": [ > "error", > "always" >+ ], >+ "prettier/prettier": [ >+ "error" > ] >- }, >- "prettier/prettier": "error" >+ } > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38149
:
172682
|
172683
|
173010
|
173011
|
173012
|
174426
|
174427
|
174428
|
174852
|
174853
|
174854
|
175424
|
175425
|
175426
|
176193
|
176194
|
176587
| 176634 |
176635
|
176636