Bugzilla – Attachment 176696 Details for
Bug 35797
REST API: Add GET route for patronimage
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35797: Add tests
Bug-35797-Add-tests.patch (text/plain), 3.74 KB, created by
William Lavoie
on 2025-01-16 17:33:26 UTC
(
hide
)
Description:
Bug 35797: Add tests
Filename:
MIME Type:
Creator:
William Lavoie
Created:
2025-01-16 17:33:26 UTC
Size:
3.74 KB
patch
obsolete
>From 3686d39e83fd243424ff7bf237c028abb4f450dd Mon Sep 17 00:00:00 2001 >From: William Lavoie <william.lavoie@inLibro.com> >Date: Thu, 16 Jan 2025 12:31:00 -0500 >Subject: [PATCH] Bug 35797: Add tests > >To run the tests, run 'prove t/db_dependent/api/v1/image.t' >--- > t/db_dependent/api/v1/image.t | 88 +++++++++++++++++++++++++++++++++++ > 1 file changed, 88 insertions(+) > create mode 100644 t/db_dependent/api/v1/image.t > >diff --git a/t/db_dependent/api/v1/image.t b/t/db_dependent/api/v1/image.t >new file mode 100644 >index 0000000000..cace53f696 >--- /dev/null >+++ b/t/db_dependent/api/v1/image.t >@@ -0,0 +1,88 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. >+# >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. >+ >+use Modern::Perl; >+ >+use Test::More tests => 1; >+use Test::Mojo; >+ >+use t::lib::TestBuilder; >+use t::lib::Mocks; >+ >+use Koha::Patrons; >+ >+my $schema = Koha::Database->new->schema; >+my $builder = t::lib::TestBuilder->new; >+ >+t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 ); >+ >+my $t = Test::Mojo->new('Koha::REST::V1'); >+ >+subtest 'Image tests' => sub { >+ >+ plan tests => 16; >+ >+ $schema->storage->txn_begin; >+ >+ my $privileged_patron = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 1 } >+ } >+ ); >+ my $password = 'thePassword123'; >+ $privileged_patron->set_password( >+ { password => $password, skip_validation => 1 } ); >+ my $userid = $privileged_patron->userid; >+ my $borrowernumber = $privileged_patron->borrowernumber; >+ >+ $t->get_ok( "//$userid:$password@/api/v1/patrons/$borrowernumber/default_image" ) >+ ->status_is(404)->json_is('/error' => 'Patron image not found.'); >+ >+ my $non_existent_patron = $builder->build_object( { class => 'Koha::Patrons' } ); >+ my $non_existent_patron_borrower_number = $non_existent_patron->borrowernumber; >+ $non_existent_patron->delete; >+ >+ $t->get_ok( "//$userid:$password@/api/v1/patrons/" . $non_existent_patron_borrower_number . '/checkouts' ) >+ ->status_is(404)->json_is('/error' => 'Patron not found'); >+ >+ my $new_image = Koha::Patron::Image->new({ >+ borrowernumber => $privileged_patron->borrowernumber, >+ mimetype => 'image/png', >+ imagefile => 'lot of binary content', >+ })->store; >+ >+ $t->get_ok( "//$userid:$password@/api/v1/patrons/$borrowernumber/default_image" ) >+ ->status_is(200)->content_type_is('image/png')->content_is('lot of binary content'); >+ >+ my $unauthorized_patron = $builder->build_object( >+ { >+ class => 'Koha::Patrons', >+ value => { flags => 0 } >+ } >+ ); >+ my $unauthorized_password = 'thePassword456'; >+ >+ $unauthorized_patron->set_password( { password => $unauthorized_password, skip_validation => 1 } ); >+ my $unauthorized_userid = $unauthorized_patron->userid; >+ >+ $t->get_ok( "//$unauthorized_userid:$unauthorized_password@/api/v1/patrons/" . $borrowernumber . "/default_image" ) >+ ->status_is(403)->json_is('/error' => "Authorization failure. Missing required permission(s)."); >+ >+ $t->get_ok( "//@/api/v1/patrons/" . $borrowernumber . "/default_image" ) >+ ->status_is(401)->json_is('/error' => 'Authentication failure.'); >+}; >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35797
:
160993
|
161273
|
161610
|
170137
|
170186
|
172201
|
176695
| 176696