Bugzilla – Attachment 176741 Details for
Bug 37273
Add ID column to Agreements table in the ERM
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37273: (follow-up) Remove parentheses and # from column
Bug-37273-follow-up-Remove-parentheses-and--from-c.patch (text/plain), 2.43 KB, created by
Lucas Gass (lukeg)
on 2025-01-17 15:14:35 UTC
(
hide
)
Description:
Bug 37273: (follow-up) Remove parentheses and # from column
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-01-17 15:14:35 UTC
Size:
2.43 KB
patch
obsolete
>From 4990afbef18e085c51b9c3fe470bb4dedd102d99 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 26 Sep 2024 19:12:13 +0000 >Subject: [PATCH] Bug 37273: (follow-up) Remove parentheses and # from column > >The new ID column shows numbers like "(#2)". I think the parentheses and >hash symbol are unnecessary and inconsistent with the way we do it in >other places and should be removed. > >To test, apply the patch and rebuild the staff interface CSS: Either run >'yarn build' from the command line or if you're using a sandbox, click >the "Actions" menu for your sandbox and choose "Build CSS and JS." > >Follow the previous test plan and confirm that the ID column looks >correct. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue | 2 +- > .../intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 8ed6d00fb94..d1616ab1c9d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -309,7 +309,7 @@ export default { > '<a href="/cgi-bin/koha/erm/agreements/' + > row.agreement_id + > '" class="show">' + >- escape_str(`(#${row.agreement_id})`) + >+ escape_str(`${row.agreement_id}`) + > "</a>" > ) > }, >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >index b5ed995152e..79fb518d88f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >@@ -200,7 +200,7 @@ export default { > '<a href="/cgi-bin/koha/erm/licenses/' + > row.license_id + > '" class="show">' + >- escape_str(`(#${row.license_id})`) + >+ escape_str(`${row.license_id}`) + > "</a>" > ) > }, >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37273
:
168606
|
169107
|
172137
|
176740
| 176741