Bugzilla – Attachment 176753 Details for
Bug 38919
Checkin does not notify of waiting holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38919: hold-found1 modal needs block class
Bug-38919-hold-found1-modal-needs-block-class.patch (text/plain), 2.00 KB, created by
Roman Dolny
on 2025-01-17 18:59:04 UTC
(
hide
)
Description:
Bug 38919: hold-found1 modal needs block class
Filename:
MIME Type:
Creator:
Roman Dolny
Created:
2025-01-17 18:59:04 UTC
Size:
2.00 KB
patch
obsolete
>From fa44079486f94c986c174d473defd827a2ca78da Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 17 Jan 2025 11:47:56 -0500 >Subject: [PATCH] Bug 38919: hold-found1 modal needs block class > >After the upgrade to Bootstrap 5, modals need either the block or >noblock class in order to be shown. The class was missing from the modal >that appears when an item is checked in after it is already waiting for >a hold. > >To test: >1. Place a hold on an item for pickup at the logged-in branch >2. Check in the item and confirm the hold >3. Check in the item again >--> There is no notification that the item is already assigned to a >waiting hold, just a "Not checked out" message >4. Apply patch >5. Navigate away from the page (we can't simply refresh the page because > we don't want to resubmit the request just yet) >6. Check in the item again >--> A modal appears notifying of the waiting hold > >Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 37dfd570b1..454d56d789 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -627,7 +627,7 @@ > > [% IF ( found ) %] > [% IF ( waiting ) %] >- <div id="hold-found1" class="modal modal-lg audio-alert-action" data-bs-backdrop="static" data-bs-keyboard="false" > >+ <div id="hold-found1" class="modal modal-lg block audio-alert-action" data-bs-backdrop="static" data-bs-keyboard="false" > > <div class="modal-dialog"> > <div class="modal-content"> > <form method="post" action="returns.pl" class="confirm"> >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38919
:
176746
|
176753
|
176759