Attachment 17681 Details for Bug 10088 – [PATCH][SIGNED OFF] Bug 10088: FIX adding an order from a staged file.

[patch] [PATCH][SIGNED OFF] Bug 10088: FIX adding an order from a staged file.

attachment.cgi?id=17668 (text/plain), 1.51 KB, created by Mathieu Saby on 2013-04-25 12:46:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Saby

Created: 2013-04-25 12:46:09 UTC

Size: 1.51 KB

patch

obsolete

>From fde4c1dcfdfe17ff61b6887da42b1dd753bfdfd9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@biblibre.com>
>Date: Thu, 25 Apr 2013 09:47:53 +0200
>Subject: [PATCH][SIGNED OFF] Bug 10088: FIX adding an order from a staged file.
>
>Bug 9902 introduced an issue in the C4::Items::PrepareItemrecordDisplay
>routine. The existence of $defaulvalue hashref should be tested before
>getting to the branchcode key.
>
>Test plan:
>Before applying the patch, an error occurred when you try to create an
>order from a staged file.
>After applying the patch, the error does not appear anymore.
>
>Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr>
>---
> C4/Items.pm |    6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/C4/Items.pm b/C4/Items.pm
>index e173dc2..89b092b 100644
>--- a/C4/Items.pm
>+++ b/C4/Items.pm
>@@ -2709,7 +2709,11 @@ sub PrepareItemrecordDisplay {
>                                 $authorised_lib{$branchcode} = $branchname;
>                             }
>                         }
>-                        $defaultvalue = $defaultvalues->{branchcode} || C4::Context->userenv->{branch};
>+
>+                        $defaultvalue = C4::Context->userenv->{branch};
>+                        if ( $defaultvalues and $defaultvalues->{branchcode} ) {
>+                            $defaultvalue = $defaultvalues->{branchcode};
>+                        }
> 
>                         #----- itemtypes
>                     } elsif ( $tagslib->{$tag}->{$subfield}->{authorised_value} eq "itemtypes" ) {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10088: 17668 | 17681 | 17750