Bugzilla – Attachment 17682 Details for
Bug 10110
Problems with diacritics in saved SQL reports
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 10110 Followup for Acquisition.pm
Bug-10110-Followup-for-Acquisitionpm.patch (text/plain), 1.05 KB, created by
Marcel de Rooy
on 2013-04-25 12:51:24 UTC
(
hide
)
Description:
Bug 10110 Followup for Acquisition.pm
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2013-04-25 12:51:24 UTC
Size:
1.05 KB
patch
obsolete
>From 2fdce51d2ba89988cd0d301230cd23ef213d90e3 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 25 Apr 2013 14:48:03 +0200 >Subject: [PATCH] Bug 10110 Followup for Acquisition.pm >Content-Type: text/plain; charset=utf-8 > >Adding a FIXE at a line that uses $sth->{NAME} for possible utf8 problems. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Acquisition.pm | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index b78a51e..77010c5 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1192,6 +1192,9 @@ sub ModOrder { > my $sth = $dbh->prepare("SELECT * FROM aqorders LIMIT 1;"); > $sth->execute; > my $colnames = $sth->{NAME}; >+ #FIXME Be careful. If aqorders would have columns with diacritics, >+ #you should need to decode what you get back from NAME. >+ #See report 10110 and guided_reports.pl > my $query = "UPDATE aqorders SET "; > > foreach my $orderinfokey (grep(!/ordernumber/, keys %$orderinfo)){ >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 10110
:
17680
|
17682
|
17683
|
17704
|
17705
|
17743
|
17744
|
17745