Bugzilla – Attachment 176864 Details for
Bug 37650
Fix warn and remove FIXME in circ/returns.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37650: Add lookahead days in CheckReserves call in returns.pl
Bug-37650-Add-lookahead-days-in-CheckReserves-call.patch (text/plain), 1.57 KB, created by
Emily Lamancusa (emlam)
on 2025-01-21 13:50:16 UTC
(
hide
)
Description:
Bug 37650: Add lookahead days in CheckReserves call in returns.pl
Filename:
MIME Type:
Creator:
Emily Lamancusa (emlam)
Created:
2025-01-21 13:50:16 UTC
Size:
1.57 KB
patch
obsolete
>From 5a3fc4187e59a252ca708525d97440df9dbe1daa Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 19 Aug 2024 11:45:14 +0000 >Subject: [PATCH] Bug 37650: Add lookahead days in CheckReserves call in > returns.pl > >Test plan: >Enable future holds. Put a positive value in ConfirmFutureHolds. >Add a hold for tomorrow and pickup at B. Check item in at A. >Confirm hold. > >Without this patch you should see a warn on L186: > [WARN] Use of uninitialized value in string ne at /usr/share/koha/circ/returns.pl line 186. >With this patch, you should not see it anymore. > >NOTE: Before bug 34972 no transfer was created for future holds. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >--- > circ/returns.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/circ/returns.pl b/circ/returns.pl >index 9f2e52dab1..67c7b008b8 100755 >--- a/circ/returns.pl >+++ b/circ/returns.pl >@@ -181,7 +181,7 @@ if ( $query->param('reserve_id') && $op eq 'cud-affect_reserve') { > } > # check if we have other reserves for this document, if we have a result send the message of transfer > # FIXME do we need to do this if we didn't take the cancel_reserve branch above? >- my ( undef, $nextreservinfo, undef ) = CheckReserves($item); >+ my ( undef, $nextreservinfo, undef ) = CheckReserves( $item, C4::Context->preference('ConfirmFutureHolds') ); > > if ( $userenv_branch ne $nextreservinfo->{'branchcode'} ) { > my $patron = Koha::Patrons->find( $nextreservinfo->{'borrowernumber'} ); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37650
:
170384
|
170466
|
176657
|
176658
|
176706
|
176707
|
176864
|
176865
|
177629
|
177630