Bugzilla – Attachment 177062 Details for
Bug 38720
HTML1 no longer valid? TT tags can be present in HTML without breaking the translator tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38720: HTML1 no longer valid - remove xt/tt_valid.t
Bug-38720-HTML1-no-longer-valid---remove-xtttvalid.patch (text/plain), 4.17 KB, created by
Jonathan Druart
on 2025-01-23 15:13:13 UTC
(
hide
)
Description:
Bug 38720: HTML1 no longer valid - remove xt/tt_valid.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-01-23 15:13:13 UTC
Size:
4.17 KB
patch
obsolete
>From 9ec6cdbe3a4a8e7f62779cd3743c9405aed13c27 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jan 2025 16:11:39 +0100 >Subject: [PATCH] Bug 38720: HTML1 no longer valid - remove xt/tt_valid.t > >--- > xt/tt_valid.t | 129 -------------------------------------------------- > 1 file changed, 129 deletions(-) > delete mode 100755 xt/tt_valid.t > >diff --git a/xt/tt_valid.t b/xt/tt_valid.t >deleted file mode 100755 >index 724bddb7d03..00000000000 >--- a/xt/tt_valid.t >+++ /dev/null >@@ -1,129 +0,0 @@ >-#!/usr/bin/perl >- >-# This file is part of Koha. >-# >-# Copyright (C) 2011 Tamil s.a.r.l. >-# >-# Koha is free software; you can redistribute it and/or modify it >-# under the terms of the GNU General Public License as published by >-# the Free Software Foundation; either version 3 of the License, or >-# (at your option) any later version. >-# >-# Koha is distributed in the hope that it will be useful, but >-# WITHOUT ANY WARRANTY; without even the implied warranty of >-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >-# GNU General Public License for more details. >-# >-# You should have received a copy of the GNU General Public License >-# along with Koha; if not, see <http://www.gnu.org/licenses>. >- >-use Modern::Perl; >-use Test::More tests => 3; >-use File::Find; >-use Cwd; >-use C4::TTParser; >- >-my @themes; >- >-# OPAC themes >-my $opac_dir = 'koha-tmpl/opac-tmpl'; >-opendir( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!"; >-for my $theme ( grep { not /^\.|lib|js|xslt/ } readdir($dh) ) { >- push @themes, "$opac_dir/$theme/en"; >-} >-close $dh; >- >-# STAFF themes >-my $staff_dir = 'koha-tmpl/intranet-tmpl'; >-opendir( $dh, $staff_dir ) or die "can't opendir $staff_dir: $!"; >-for my $theme ( grep { not /^\.|lib|js/ } readdir($dh) ) { >- push @themes, "$staff_dir/$theme/en"; >-} >-close $dh; >- >-my $checkers = [ >- { >- description => 'TT syntax: not using TT directive within HTML tag', >- check => sub { >- my ( $self, $name, $token ) = @_; >- my $attr = $token->{_attr}; >- next unless $attr; >- push @{ $self->{errors}->{$name} }, $token->{_lc} if $attr->{'[%'} or $attr->{'[%-'}; >- }, >- errors => {}, >- }, >- { >- description => '<body> tag with id and class attributes', >- check => sub { >- my ( $self, $name, $token ) = @_; >- return if $name =~ /bodytag\.inc/; >- my $tag = $token->{_string}; >- push @{ $self->{errors}->{$name} }, $token->{_lc} >- if $tag =~ /^<body/ >- && ( $tag !~ /id=".+"/ || $tag !~ /class=".+"/ ); >- }, >- errors => {}, >- }, >-]; >-find( >- sub { >- my $dir = getcwd(); >- return if $dir =~ /blib/; >- return unless /\.(tt|inc)$/; >- ($dir) = $dir =~ /koha-tmpl\/(.*)$/; >- my $name = $_; >- my $parser = C4::TTParser->new; >- $parser->build_tokens($name); >- while ( my $token = $parser->next_token ) { >- my $attr = $token->{_attr}; >- next unless $attr; >- for my $checker (@$checkers) { >- $checker->{check}->( $checker, "$dir/$name", $token ); >- } >- } >- }, >- @themes >-); >- >-for my $check (@$checkers) { >- my @files = sort keys %{ $check->{errors} }; >- ok( !@files, $check->{description} ) >- or diag( >- "Files list: \n", >- join( "\n", map { "$_: " . join( ', ', @{ $check->{errors}->{$_} } ) } @files ) >- ); >-} >- >-my $testtoken = 0; >-my $ttparser = C4::TTParser->new(); >-$ttparser->unshift_token($testtoken); >-my $testtokenagain = C4::TTParser::next_token(); >-is( $testtoken, $testtokenagain, "Token received same as original put on stack" ); >- >-=head1 NAME >- >-tt_valid.t >- >-=head1 DESCRIPTION >- >-This test validate Template Toolkit (TT) Koha files. >- >-For the time being, two validations are done: >- >-[1] Test if TT files contain TT directive within HTML tag. For example: >- >- <li[% IF >- >-This kind of construction MUST be avoided because it breaks Koha translation >-process. >- >-[2] Test tag <body> tags have both attibutes 'id' and 'class' >- >-=head1 USAGE >- >-From Koha root directory: >- >-prove -v xt/tt_valid.t >- >-=cut >- >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38720
: 177062