Bugzilla – Attachment 177104 Details for
Bug 37918
Properly encode email subjects in mailto: links
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37918: Correct usage
Bug-37918-Correct-usage.patch (text/plain), 11.34 KB, created by
Paul Derscheid
on 2025-01-24 11:12:31 UTC
(
hide
)
Description:
Bug 37918: Correct usage
Filename:
MIME Type:
Creator:
Paul Derscheid
Created:
2025-01-24 11:12:31 UTC
Size:
11.34 KB
patch
obsolete
>From 2ffe7d5d2621398d10885727fb87469189522afa Mon Sep 17 00:00:00 2001 >From: Paul Derscheid <paul.derscheid@lmscloud.de> >Date: Fri, 24 Jan 2025 12:04:14 +0100 >Subject: [PATCH] Bug 37918: Correct usage > >--- > koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc | 2 +- > .../intranet-tmpl/prog/en/modules/circ/branchoverdues.tt | 4 ++-- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt | 2 +- > .../intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt | 2 +- > .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 2 +- > .../intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 2 +- > 7 files changed, 9 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index 3a58e4768d..b5be84a35a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -56,7 +56,7 @@ > <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% reserveloo.borrower.borrowernumber | uri %]">[% INCLUDE 'patron-title.inc' patron=reserveloo.borrower invert_name=1 no_title=1 %]</a> > [% IF ( reserveloo.borrower.phone ) %]<br /><span class="patron_phone">[% reserveloo.borrower.phone | html %]</span>[% END %] > [% IF ( reserveloo.borrower.notice_email_address ) %] >- <span class="patron_email"><br /><a href="mailto:[% reserveloo.borrower.notice_email_address | uri %]?subject=[% "Hold waiting: " | email_header %][% reserveloo.biblio.title | email_header %]"> >+ <span class="patron_email"><br /><a href="mailto:[% reserveloo.borrower.notice_email_address | uri %]?subject=[% "Hold waiting: " | $EmailHeader %][% reserveloo.biblio.title | $EmailHeader %]"> > [% reserveloo.borrower.notice_email_address | html %]</a></span> > [% END %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >index 9d57e3309b..d74ade50fe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchoverdues.tt >@@ -74,7 +74,7 @@ > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% overduesloo.borrowernumber | uri %]">[% overduesloo.borrowersurname | html %], [% overduesloo.borrowerfirstname | html %]</a> > <br />[% overduesloo.cardnumber | html %] > <br />[% overduesloo.borrowerphone | html %]<br /> >- [% IF ( overduesloo.borroweremail ) %]<a href="mailto:[% overduesloo.borroweremail | uri %]?subject=Overdue: [% overduesloo.title | email_header %]"> >+ [% IF ( overduesloo.borroweremail ) %]<a href="mailto:[% overduesloo.borroweremail | uri %]?subject=Overdue: [% overduesloo.title | $EmailHeader %]"> > [% overduesloo.borroweremail | html %]</a>[% END %] > </td> > <td>[% Branches.GetName( overduesloo.homebranch ) | html %] [% overduesloo.itemcallnumber | html %] >@@ -115,7 +115,7 @@ > <p><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% todayoverduesloo.borrowernumber | uri %]">[% todayoverduesloo.borrowersurname | html %] [% todayoverduesloo.borrowerfirstname | html %]</a> > <br />[% todayoverduesloo.cardnumber | html %]<br /> > <br />[% todayoverduesloo.borrowerphone | html %]<br /> >- [% IF ( todayoverduesloo.borroweremail ) %]<a href="mailto:[% todayoverduesloo.borroweremail | uri %]?subject=Overdue: [% todayoverduesloo.title | email_header %]"> >+ [% IF ( todayoverduesloo.borroweremail ) %]<a href="mailto:[% todayoverduesloo.borroweremail | uri %]?subject=Overdue: [% todayoverduesloo.title | $EmailHeader %]"> > [% todayoverduesloo.borroweremail | html %]</a>[% END %] > </p> > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >index 0163da8d27..24697e87fe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/overdue.tt >@@ -112,7 +112,7 @@ > <td> > [% INCLUDE 'patron-title.inc' patron=overdueloo.patron hide_patron_infos_if_needed=1 %] > [% IF logged_in_user.can_see_patron_infos( overdueloo.patron ) %] >- [% IF ( overdueloo.email ) %][<a href="mailto:[% overdueloo.email | uri %]?subject=[% INCLUDE subject %] [% overdueloo.title | email_header %]">email</a>][% END %] >+ [% IF ( overdueloo.email ) %][<a href="mailto:[% overdueloo.email | uri %]?subject=[% INCLUDE subject %] [% overdueloo.title | $EmailHeader %]">email</a>][% END %] > [% IF ( overdueloo.phone ) %]([% overdueloo.phone | html %])[% ELSIF ( overdueloo.mobile ) %]([% overdueloo.mobile | html %])[% ELSIF ( overdueloo.phonepro ) %]([% overdueloo.phonepro | html %])[% END %] > [% END %] > </td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >index 15b0db4c3e..f2d274a13f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstoreceive.tt >@@ -82,7 +82,7 @@ > [% IF ( reser.patron.notice_email_address ) %] > <br /> > [% BLOCK subject %]Hold:[% END %] >- <a href="mailto:[% reser.patron.notice_email_address | uri %]?subject=[% INCLUDE subject %] [% reser.title | email_header %]"> >+ <a href="mailto:[% reser.patron.notice_email_address | uri %]?subject=[% INCLUDE subject %] [% reser.title | $EmailHeader %]"> > [% reser.patron.notice_email_address | html %] > </a> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >index f2f399cb7b..5620418026 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt >@@ -234,7 +234,7 @@ > <p>[% itemsloo.patron.phone | html %]</p> > [% IF itemsloo.patron.notice_email_address %] > <p class="patron-email"> >- <a href="mailto:[% itemsloo.patron.notice_email_address | uri %]?subject=[% itemsloo.title | email_header%]"> >+ <a href="mailto:[% itemsloo.patron.notice_email_address | uri %]?subject=[% itemsloo.title | $EmailHeader %]"> > [% itemsloo.patron.notice_email_address | html %]</a> > </p> > [% END %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >index d8eb946961..eec8c17eca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/recalls_waiting.tt >@@ -75,7 +75,7 @@ > <td class="recall-patron"> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.patron_id | uri %]">[% recall.patron.firstname | html %] [% recall.patron.surname | html %]</a> > [% IF ( recall.patron.phone ) %]<br />[% recall.patron.phone | html %][% END %] >- [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email | uri %]?subject=Recall waiting: [% recall.biblio.title | email_header %]">[% recall.patron.email | html %]</a>[% END %] >+ [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email | uri %]?subject=Recall waiting: [% recall.biblio.title | $EmailHeader %]">[% recall.patron.email | html %]</a>[% END %] > </td> > <td class="recall-library">[% recall.library.branchname | html %]</td> > <td class="recall-action actions"> >@@ -120,7 +120,7 @@ > <td class="recall-patron"> > <a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% recall.patron_id | uri %]">[% recall.patron.firstname | html %] [% recall.patron.surname | html %]</a> > [% IF ( recall.patron.phone ) %]<br />[% recall.patron.phone | html %][% END %] >- [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email | uri %]?subject=Recall waiting: [% recall.biblio.title | email_header %]">[% recall.patron.email | html %]</a>[% END %] >+ [% IF ( recall.patron.email ) %]<br /><a href="mailto:[% recall.patron.email | uri %]?subject=Recall waiting: [% recall.biblio.title | $EmailHeader %]">[% recall.patron.email | html %]</a>[% END %] > </td> > <td class="recall-library">[% recall.library.branchname | html %]</td> > <td class="recall-action actions"> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 759350d50b..1d069d9092 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -1096,7 +1096,7 @@ > [% CASE "linkedin" -%] > <div><a id="linkedin" href="https://www.linkedin.com/shareArticle?mini=true&url=[% current_url |url %]&title=[% title |url %]" title="Share on LinkedIn"><i class="fab fa-linkedin" aria-hidden="true"></i></a></div> > [% CASE "email" -%] >- <div><a id="email" href="mailto:?subject=[% title | email_header %]&body=[% title | url %]%20([% current_url |url %])" title="Share by email"><i class="fa-solid fa-envelope" aria-hidden="true"></i></a></div> >+ <div><a id="email" href="mailto:?subject=[% title | $EmailHeader %]&body=[% title | url %]%20([% current_url |url %])" title="Share by email"><i class="fa-solid fa-envelope" aria-hidden="true"></i></a></div> > [% END # /SWITCH network -%] > [% END # /FOREACH network %] > </div> <!-- /#social_networks --> >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37918
:
171518
|
171994
|
176576
|
176869
|
176870
|
176871
|
176873
|
176874
|
176875
|
177103
| 177104