Bugzilla – Attachment 177126 Details for
Bug 38528
Additional fields are not properly fetched in serial subscription details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38528: (follow-up) add test for prepare_cgi_additional_field_values
Bug-38528-follow-up-add-test-for-preparecgiadditio.patch (text/plain), 1.88 KB, created by
Pedro Amorim
on 2025-01-24 16:00:44 UTC
(
hide
)
Description:
Bug 38528: (follow-up) add test for prepare_cgi_additional_field_values
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2025-01-24 16:00:44 UTC
Size:
1.88 KB
patch
obsolete
>From fa0e64e4e2b915cb1c5b86b6bdb05ff322181d94 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Thu, 23 Jan 2025 17:11:00 +0100 >Subject: [PATCH] Bug 38528: (follow-up) add test for > prepare_cgi_additional_field_values > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../Koha/Object/Mixin/AdditionalFields.t | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t b/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t >index 2b801e19c1c..8026032307c 100755 >--- a/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t >+++ b/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t >@@ -242,6 +242,13 @@ subtest 'prepare_cgi_additional_field_values' => sub { > } > ); > $field2->store()->discard_changes(); >+ my $field3 = Koha::AdditionalField->new( >+ { >+ tablename => 'subscription', >+ name => random_string( 'c' x 100 ) >+ } >+ ); >+ $field3->store()->discard_changes(); > > my $q = CGI->new; > $q->param( >@@ -252,6 +259,10 @@ subtest 'prepare_cgi_additional_field_values' => sub { > -name => 'additional_field_' . $field2->id, > -value => '0', > ); >+ $q->param( >+ -name => 'additional_field_' . $field3->id, >+ -value => '', >+ ); > $q->param( > -name => 'irrelevant_param', > -value => 'foo', >@@ -274,13 +285,15 @@ subtest 'prepare_cgi_additional_field_values' => sub { > { > 'value' => '0', > 'id' => $field2->id >+ }, >+ { >+ 'value' => '', >+ 'id' => $field3->id > } > ], > 'Return of prepare_cgi_additional_field_values should be correct' > ); >- > $schema->txn_rollback; >- > }; > > subtest 'strings_map() tests' => sub { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38528
:
174978
|
175480
|
175647
|
175689
|
177064
|
177125
|
177126
|
177127
|
177168
|
177169
|
177170