Bugzilla – Attachment 177198 Details for
Bug 38040
IndependentBranches doesn't prevent editing other libraries' holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38040: Prevent editing other libraries' holds when IndependentBranches is enabled
Bug-38040-Prevent-editing-other-libraries-holds-wh.patch (text/plain), 2.12 KB, created by
William Lavoie
on 2025-01-27 19:51:14 UTC
(
hide
)
Description:
Bug 38040: Prevent editing other libraries' holds when IndependentBranches is enabled
Filename:
MIME Type:
Creator:
William Lavoie
Created:
2025-01-27 19:51:14 UTC
Size:
2.12 KB
patch
obsolete
>From 5d3e8b36341c45644a6e883f82fdfc6e72ba2168 Mon Sep 17 00:00:00 2001 >From: William Lavoie <william.lavoie@inLibro.com> >Date: Mon, 27 Jan 2025 14:49:24 -0500 >Subject: [PATCH] Bug 38040: Prevent editing other libraries' holds when > IndependentBranches is enabled > >--- > .../intranet-tmpl/prog/en/modules/reserve/request.tt | 4 ++-- > reserve/request.pl | 8 ++++---- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index b625fd36d7..00720dbe06 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1866,8 +1866,8 @@ > return false; > }); > >- [% IF (!is_super_librarian) %] >- var user_branch = "[% user_branch %]"; >+ [% IF (!CAN_user_superlibrarian) %] >+ var user_branch = "[% Branches.GetLoggedInBranchcode %]"; > if(user_branch !== undefined && user_branch !== ""){ > $('#patron_holds_table tbody tr').each(function() { > var link = $(this).find('a[href*="member"]'); >diff --git a/reserve/request.pl b/reserve/request.pl >index d06b6a5aba..c8006385bd 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -121,10 +121,10 @@ if ( $op eq 'cud-move' ) { > } > } > elsif ( $op eq 'cud-cancel' ) { >- my $reserve_id = $input->param('reserve_id'); >- my $cancellation_reason = $input->param("cancellation-reason"); >- my $hold = Koha::Holds->find($reserve_id); >- $hold->cancel( { cancellation_reason => $cancellation_reason } ) if $hold; >+ my $reserve_id = $input->param('reserve_id'); >+ my $cancellation_reason = $input->param("cancellation-reason"); >+ my $hold = Koha::Holds->find($reserve_id); >+ $hold->cancel( { cancellation_reason => $cancellation_reason } ) if $hold; > } > elsif ( $op eq 'cud-setLowestPriority' ) { > my $reserve_id = $input->param('reserve_id'); >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38040
:
173400
|
176050
|
177197
|
177198
|
177292
|
177472
|
177492
|
178014
|
178015
|
178016
|
179186
|
179187
|
179714
|
180531
|
180532
|
180581
|
180582
|
180898
|
180899
|
180900
|
182444
|
182445
|
182446
|
182447