Bugzilla – Attachment 177246 Details for
Bug 26553
Remove KohaTable (columns_settings.inc) and use kohaTable (datatables.js)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Bug-26553-Fix-incorrect-occurrences-of-sortable--o.patch (text/plain), 14.19 KB, created by
Jonathan Druart
on 2025-01-28 10:13:49 UTC
(
hide
)
Description:
Bug 26553: Fix incorrect occurrences of 'sortable' => 'orderable'
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-01-28 10:13:49 UTC
Size:
14.19 KB
patch
obsolete
>From fe66281ccf5abb0a3e8320f234de5e6152b30ff6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Jan 2025 10:35:18 +0100 >Subject: [PATCH] Bug 26553: Fix incorrect occurrences of 'sortable' => > 'orderable' > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt | 4 ++-- > .../prog/en/modules/admin/auth_subfields_structure.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt | 2 +- > .../intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt | 2 +- > .../prog/en/modules/patron_lists/patron-lists-tab.tt | 2 +- > .../prog/en/modules/tools/additional-contents.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt | 2 +- > .../opac-tmpl/bootstrap/en/modules/opac-search-history.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt | 2 +- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- > 17 files changed, 18 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >index c98ea862c2e..3845a8e180e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt >@@ -411,7 +411,7 @@ > [% ELSE %] > grouped = $("#grouped").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > autoWidth: false, > language: { > emptyTable: _("There are no baskets in this group"), >@@ -419,7 +419,7 @@ > }); > ungrouped = $("#ungrouped").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > autoWidth: false, > language: { > emptyTable: _("There are no ungrouped baskets"), >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >index e68e58a45ff..918b41ba78b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_subfields_structure.tt >@@ -412,7 +412,7 @@ > <script> > $(document).ready(function() { > $("#table_authsubfieldstructure").kohaTable({ >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > aaSorting: [], > paginate: false, > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >index 9210dfa6257..bdd51a07367 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/localization.tt >@@ -186,7 +186,7 @@ > > var table = $("#localization").kohaTable({ > dom: "t", >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > paginate: false, > autoWidth: false, > }); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >index 430d9fb4d02..8cc9ea62fe0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/oai_servers.tt >@@ -222,7 +222,7 @@ > [% ELSE %] > $(document).ready(function() { > $("#serverst").kohaTable({ >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > pagingType: "full", > }); > $(".delete").on("click",function(e){ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >index 644f35554f1..eee6e66df59 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/patron-clubs-tab.tt >@@ -68,7 +68,7 @@ > > <script> > var clubs_dt_params = { >- columnDefs: [{ sortable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, targets: ["NoSort"] }], > paginate: true, > }; > $("#table_clubnoenrollmemnts").kohaTable(clubs_dt_params); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >index 13e33153251..2369be6b1b3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/patron-lists-tab.tt >@@ -105,7 +105,7 @@ > > <script> > var patron_lists_dt_params = { >- columnDefs: [{ sortable: false, bSearchable: false, targets: ["NoSort"] }], >+ columnDefs: [{ orderable: false, bSearchable: false, targets: ["NoSort"] }], > sPaginationType: "full", > }; > $("#table_listnopatron").kohaTable(patron_lists_dt_params); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >index 2faee1b7d64..8ec41db0d57 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt >@@ -606,7 +606,7 @@ > var table = $("#table_additional_contents").kohaTable({ > order: [[4, "desc"]], > columnDefs: [ >- { sortable: false, searchable: false, targets: ["NoSort"] }, >+ { orderable: false, searchable: false, targets: ["NoSort"] }, > { type: "anti-the", targets: ["anti-the"] }, > ], > pagingType: "full_numbers", >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >index 117952f020e..b198f91f97e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-basket.tt >@@ -500,7 +500,7 @@ > if( $("#itemst").length > 0 ){ > var itemst = $("#itemst").kohaTable({ > order: [[1, "asc"]], >- columnDefs: [{ targets: [0, -1], sortable: false, searchable: false }], >+ columnDefs: [{ targets: [0, -1], orderable: false, searchable: false }], > columns: [null, { type: "anti-the" }, null, null, null], > }); > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >index c239a1a676b..157875d0b3c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-idref.tt >@@ -54,7 +54,7 @@ > $(document).ready(function (){ > $("table").kohaTable({ > filter: false, >- columnDefs: [{ targets: [-1, -2], sortable: false }], >+ columnDefs: [{ targets: [-1, -2], orderable: false }], > }); > > $(".role").click(function(){ >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >index 18a84287f66..cc7fde55259 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-illrequests.tt >@@ -341,7 +341,7 @@ > [% INCLUDE 'datatables.inc' %] > <script> > $("#illrequestlist").kohaTable({ >- columnDefs: [{ targets: [-1], sortable: false, searchable: false }], >+ columnDefs: [{ targets: [-1], orderable: false, searchable: false }], > order: [[3, "desc"]], > }); > $("#backend-dropdown-options").removeClass("nojs"); >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >index 71d0e795dc6..2c79687ba26 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recalls.tt >@@ -140,7 +140,7 @@ > details: { type: "column", target: -1 }, > }, > columnDefs: [ >- { targets: ["nosort"], sortable: false, searchable: false }, >+ { targets: ["nosort"], orderable: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >index 35bc1b4581d..d7021516e3e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt >@@ -297,7 +297,7 @@ > order: [[1, "desc"]], > dom: '<"top"<"table_entries"><"table_controls"fB>>t', > columnDefs: [ >- { targets: [0], sortable: false, searchable: false }, >+ { targets: [0], orderable: false, searchable: false }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], > language: { >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index cf4925be4e1..46717afa511 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -567,7 +567,7 @@ > $("#suggestt").kohaTable({ > "order": [[ 1, "asc" ]], > "columnDefs": [ >- [% IF ( loggedinusername ) %]{ "targets": [ 0 ], "sortable": false, "searchable": false }[% END %], >+ [% IF ( loggedinusername ) %]{ "targets": [ 0 ], "orderable": false, "searchable": false }[% END %], > { "className": 'dtr-control', "orderable": false, "targets": -1 }, > { responsivePriority: 1, targets: 1 } > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index 2f907cdc49d..788ba44d31e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -262,7 +262,7 @@ > $("#mytagst").kohaTable({ > sorting: [[2, "asc"]], > columnDefs: [ >- { targets: [0], sortable: false, searchable: false }, >+ { targets: [0], orderable: false, searchable: false }, > { sType: "anti-the", aTargets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > { responsivePriority: 1, targets: 2 }, >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >index 2a71cdcef75..9b0d75ff90b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt >@@ -148,7 +148,7 @@ > $("#topissuest").kohaTable({ > sorting: [[3, "desc"]], > columnDefs: [ >- { sortable: false, searchable: false, targets: ["NoSort"] }, >+ { orderable: false, searchable: false, targets: ["NoSort"] }, > { type: "anti-the", targets: ["anti-the"] }, > { className: "dtr-control", orderable: false, targets: -1 }, > ], >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >index 16dce0edbef..c1c07725624 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt >@@ -1209,7 +1209,7 @@ > "sorting" : [[ thIndex, 'asc' ]], > "dom": '<"top"<"table_entries"><"table_controls"fB>>t', > "columnDefs": [ >- { "targets": [ "nosort" ],"sortable": false,"searchable": false }, >+ { "targets": [ "nosort" ],"orderable": false,"searchable": false }, > { "type": "anti-the", "targets" : [ "anti-the" ] }, > { "visible": false, "targets" : [ "hidden" ] }, > { "className": 'dtr-control', "orderable": false, "targets": -1 } >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index 86c5aa72e06..c068e08f63b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -603,7 +603,7 @@ > sorting: [[thIndex, "asc"]], > dom: '<"top"<"table_entries"><"table_controls"f>>t<"clear">', > columnDefs: [ >- { targets: ["nosort"], sortable: false, searchable: false }, >+ { targets: ["nosort"], orderable: false, searchable: false }, > { targets: ["noshow"], visible: false, searchable: false }, > { type: "anti-the", targets: ["anti-the"] }, > { visible: false, targets: ["hidden"] }, >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26553
:
175186
|
175187
|
175188
|
175189
|
175190
|
175191
|
175874
|
175875
|
175876
|
175877
|
175878
|
175879
|
176359
|
176360
|
176361
|
176362
|
176363
|
176364
|
176588
|
176589
|
176590
|
176591
|
177087
|
177088
|
177089
|
177090
|
177091
|
177092
|
177152
|
177153
|
177154
|
177155
|
177156
|
177157
|
177158
|
177234
|
177235
|
177236
|
177237
|
177238
|
177239
|
177240
|
177241
|
177242
|
177243
|
177246
|
177247
|
177264
|
177265
|
177271
|
177888
|
177889
|
177890
|
177891
|
177892
|
177893
|
177894
|
177895
|
177896
|
177897
|
177898
|
177899
|
177900
|
178508
|
178509
|
178510
|
178511
|
178512
|
178513
|
178514
|
178515
|
178516
|
178517
|
178518
|
178519
|
178520
|
178521
|
178522
|
178523
|
178524
|
178525
|
178526
|
178527
|
178528
|
178529
|
178530
|
178531
|
178532
|
178533