Bugzilla – Attachment 177252 Details for
Bug 37211
All notes in the patron Transactions table should be editable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37211: (QA follow-up) Update for bootstrap5 and remove copy/paste
Bug-37211-QA-follow-up-Update-for-bootstrap5-and-r.patch (text/plain), 4.00 KB, created by
Martin Renvoize (ashimema)
on 2025-01-28 10:40:54 UTC
(
hide
)
Description:
Bug 37211: (QA follow-up) Update for bootstrap5 and remove copy/paste
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2025-01-28 10:40:54 UTC
Size:
4.00 KB
patch
obsolete
>From 4d975f62a8e085bd721f2f5a82237068aeeed8f0 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 28 Jan 2025 10:38:54 +0000 >Subject: [PATCH] Bug 37211: (QA follow-up) Update for bootstrap5 and remove > copy/paste > >There were some unneeded data elements being passed around and we also >needed to update from data- to data-bs- in places to get the modals >working again. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/members/boraccount.tt | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 5e5b9b04ef0..8098a130058 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -134,7 +134,7 @@ > <td> > [% account.note | html_line_break %] > [% IF CAN_user_updatecharges_edit_notes %] >- <button type="button" class="btn btn-default btn-xs edit-action" data-toggle="modal" data-target="#editNoteModal" data-accountline="[% account.accountlines_id | html %]" data-note="[% account.note | html %]" data-member="[% account.borrowernumber | html %]"><i class="fa-solid fa-pen"></i> Edit</button> >+ <button type="button" data-bs-toggle="modal" data-bs-target="#editNoteModal" data-accountline="[% account.accountlines_id | html %]" data-note="[% account.note | html %]" class="btn btn-default btn-xs edit-action" ><i class="fa-solid fa-pen"></i> Edit</button> > [% END %] > </td> > [% IF account.amount <= 0 %]<td class="credit" style="text-align: right;">[% ELSE %]<td class="debit" style="text-align: right;">[% END %][% account.amount | $Price %]</td> >@@ -463,22 +463,22 @@ > <div class="modal-dialog" role="document"> > <div class="modal-content"> > <div class="modal-header"> >- <button type="button" class="closebtn" data-dismiss="modal" aria-label="Close"><span aria-hidden="true">×</span></button> >- <h4 class="modal-title" id="editNoteLabel">Edit note</h4> >+ <h1 class="modal-title" id="editNoteLabel">Edit note</h1> >+ <button type="button" class="btn-close" data-bs-dismiss="modal" aria-label="Close"></button> > </div> > <div class="modal-body"> > <fieldset class="rows"> > <ol> > <li> > <label for="edited_note">Note: </label> >- <input name="edited_note" id="edited_note" value="" /> >+ <input type="text" name="edited_note" id="edited_note" value="" /> > </li> > </ol> > </fieldset> <!-- /.rows --> > </div> <!-- /.modal-body --> > <div class="modal-footer"> >- <button type="submit" class="btn btn-default">Confirm</button> >- <button type="button" class="btn btn-default" data-dismiss="modal">Cancel</button> >+ <button type="submit" class="btn btn-primary">Confirm</button> >+ <button type="button" class="btn btn-default" data-bs-dismiss="modal">Cancel</button> > </div> <!-- /.modal-footer --> > </div> <!-- /.modal-content --> > </div> <!-- /.modal-dialog --> >@@ -575,8 +575,6 @@ > > $("#editNoteModal").on("shown.bs.modal", function(e){ > var button = $(e.relatedTarget); >- var item = button.data('item'); >- $("#item + span").replaceWith(item); > var accountline = button.data('accountline'); > $('#noteline').val(accountline); > var note = button.data('note'); >-- >2.48.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37211
:
168211
|
168212
|
170002
|
170003
|
170218
|
170219
|
177244
|
177245
|
177248
|
177249
|
177250
|
177251
| 177252 |
177261