Attachment 17728 Details for Bug 10022 – [SIGNED-OFF] Bug 10022 - Multiple tags moderation doesn't work on translated page

[patch] [SIGNED-OFF] Bug 10022 - Multiple tags moderation doesn't work on translated page

SIGNED-OFF-Bug-10022---Multiple-tags-moderation-do.patch (text/plain), 3.02 KB, created by Owen Leonard on 2013-04-26 17:56:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2013-04-26 17:56:11 UTC

Size: 3.02 KB

patch

obsolete

>From 6e23011f894c48ae21f8fa442a078c86db14c0eb Mon Sep 17 00:00:00 2001
>From: Fridolyn SOMERS <fridolyn.somers@biblibre.com>
>Date: Wed, 10 Apr 2013 12:37:54 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 10022 - Multiple tags moderation doesn't
> work on translated page
>Content-Type: text/plain; charset="utf-8"
>
>When using a translated intranet, tags moderation using checkboxes and a
>submit button doesn't work. You get a message "Unknown Operation on x
>Term(s)" (translated of course).
>
>This patch corrects by using name="op-[operation]" instead of name="op"
>in each submit input.
>
>Test plan :
>- Create a new tag on a record
>- Go to tags moderation in Tools
>=> You should see your tag in pending terms
>- Click on checkbox
>- Click on Approve or Reject submit button at the bottom of the table
>=> Without patch the tag is still pending
>=> With patch operation is well performed, tag is not pending
>- Test "Check lists" form
>- Test Approve and Reject buttons from "Actions" column
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> .../intranet-tmpl/prog/en/modules/tags/review.tt   |    6 +++---
> tags/review.pl                                     |    7 ++++++-
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>index e1dc698..a3b1e22 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt
>@@ -239,8 +239,8 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
>   </table>
>   [% END %]
>     [% IF ( tagloop ) %]<fieldset class="action">
>-   <input type="submit" value="Approve" id="approve_button" name="op" />
>-   <input type="submit" value="Reject"  id="reject_button"  name="op" />
>+   <input type="submit" value="Approve" id="approve_button" name="op-approve" />
>+   <input type="submit" value="Reject"  id="reject_button"  name="op-reject" />
>   </fieldset>[% END %]
>   </form>
> </div>
>@@ -268,7 +268,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
>    <div class="description">Enter a word or phrase to check against approved/rejected lists: </div>
>    <form method="post" action="/cgi-bin/koha/tags/review.pl">
>    <input type="text" size="14" name="test" id="test" />
>-   <fieldset class="action"><input type="submit" value="Test" id="test_button" name="op" /></fieldset>
>+   <fieldset class="action"><input type="submit" value="Test" id="test_button" name="op-test" /></fieldset>
>    <div id="verdict">
> 	[% IF ( test_term ) %]
> 	[% IF ( verdict_ok ) %]
>diff --git a/tags/review.pl b/tags/review.pl
>index 5405924..3f4cc50 100755
>--- a/tags/review.pl
>+++ b/tags/review.pl
>@@ -89,7 +89,12 @@ my ($template, $borrowernumber, $cookie) = get_template_and_user({
> });
> 
> my ($op, @errors, @tags);
>-$op   = lc($input->param('op')) || 'none';
>+
>+foreach (qw( approve reject test )) {
>+    $op = $_ if ( $input->param("op-$_") );
>+}
>+$op ||= 'none';
>+
> @tags = $input->param('tags');
> 
> $borrowernumber == 0 and push @errors, {op_zero=>1};
>-- 
>1.7.9.5

Actions: View | Diff | Splinter Review

Attachments on bug 10022: 17338 | 17728 | 17780