Bugzilla – Attachment 177285 Details for
Bug 38986
Restore "Any" option to purchase suggestion filter by fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38986: Restore ANY filter on suggestions.ttype
Bug-38986-Restore-ANY-filter-on-suggestionsttype.patch (text/plain), 1.78 KB, created by
Biblibre Sandboxes
on 2025-01-28 16:22:01 UTC
(
hide
)
Description:
Bug 38986: Restore ANY filter on suggestions.ttype
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2025-01-28 16:22:01 UTC
Size:
1.78 KB
patch
obsolete
>From a2324113a4c7cb4771f93f04647f5441e5fb29c1 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Tue, 28 Jan 2025 15:41:27 +0000 >Subject: [PATCH] Bug 38986: Restore ANY filter on suggestions.ttype > >To test: >1 - have two suggestions, one with a fund assigned and one without >2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option >3 - apply patch, reload page >4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly > >Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> >--- > .../prog/en/modules/suggestion/suggestion.tt | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 8c2fcf15db..052556e8ac 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1273,14 +1273,11 @@ > [% BLOCK funds_dropdown %] > <label for="budgetid">Fund:</label> > <select name="budgetid" id="budgetid"> >- [% IF op == 'save' %] >- <option value="">Any</option> >+ <option value="">Any</option> >+ [% IF budgetid == '__NONE__' %] >+ <option value="__NONE__" selected="selected">None</option> > [% ELSE %] >- [% IF budgetid == '__NONE__' %] >- <option value="__NONE__" selected="selected">None</option> >- [% ELSE %] >- <option value="__NONE__">None</option> >- [% END %] >+ <option value="__NONE__">None</option> > [% END %] > [% FOREACH budget IN sugg_budgets %] > [% IF ( budget.selected ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38986
:
177282
|
177285
|
177473
|
177474
|
177494