Bugzilla – Attachment 17730 Details for
Bug 9266
Untranslated strings in tags moderation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9266 - Untranslated strings in tags moderation
Bug-9266---Untranslated-strings-in-tags-moderation.patch (text/plain), 2.70 KB, created by
Owen Leonard
on 2013-04-26 18:31:43 UTC
(
hide
)
Description:
Bug 9266 - Untranslated strings in tags moderation
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-04-26 18:31:43 UTC
Size:
2.70 KB
patch
obsolete
>From d731369b3af1a418c8fa47e2c0c2662e506f141c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 26 Apr 2013 14:20:49 -0400 >Subject: [PATCH] Bug 9266 - Untranslated strings in tags moderation >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit >Content-Type: text/plain; charset="utf-8" > >There are a couple of English strings in tags moderation JavaScript >which are not properly enclosed in the _() function enabling >translation. As a result, clicking a translated 'Approve' or >'Reject' button in the table of tags would change the button's >neighbor's label to the English string. This patch >corrects it. > >To test, apply the patch and regenerate a translation to test with. Go >to Tools -> Tags and find a list of tags to moderate (pending, approved, >or rejected). When you click on an 'Approve' or 'Reject' tag in the >table of tags, the buttons in each Approve/Reject pair should retain >their correct translated label. For instance, looking at approved tags >in French: > >[ Approuvé ] [ Rejeter ] > >Clicking the "Rejetee" button should change the state to: > >[ Approuver ] [ Rejetée ] > >Clicking "Approuver" should return the buttons to the first state. >--- > .../intranet-tmpl/prog/en/modules/tags/review.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >index e1dc698..331f8fb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt >@@ -96,7 +96,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; } > "data": {ok: $(event.target).attr("title")}, > "success": count_approve // success_approve > }); >- $(event.target).next(".rej").removeAttr("disabled").attr("value","Reject").css("color","#000"); >+ $(event.target).next(".rej").removeAttr("disabled").attr("value",_("Reject")).css("color","#000"); > $(event.target).attr( "value",_("Approved")).attr("disabled","disabled").css("color","#666"); > return false; // cancel submit > } >@@ -105,7 +105,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; } > "data": {rej: $(event.target).attr("title")}, > "success": count_reject // success_reject > }); >- $(event.target).prev(".ok").removeAttr("disabled").attr("value","Approve").css("color","#000"); >+ $(event.target).prev(".ok").removeAttr("disabled").attr("value",_("Approve")).css("color","#000"); > $(event.target).attr( "value",_("Rejected")).attr("disabled","disabled").css("color","#666"); > return false; // cancel submit > } >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9266
:
14013
|
17730
|
17761
|
17778