Bugzilla – Attachment 177305 Details for
Bug 34778
Add a 'Show password'/eye icon to toggle visibility of password when logging into OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34778: (follow-up) Remove the include file
Bug-34778-follow-up-Remove-the-include-file.patch (text/plain), 2.46 KB, created by
David Cook
on 2025-01-28 23:06:04 UTC
(
hide
)
Description:
Bug 34778: (follow-up) Remove the include file
Filename:
MIME Type:
Creator:
David Cook
Created:
2025-01-28 23:06:04 UTC
Size:
2.46 KB
patch
obsolete
>From 80187aca1dbfedf52156739002925c7ca2f0e177 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 28 Jan 2025 14:26:14 +0100 >Subject: [PATCH] Bug 34778: (follow-up) Remove the include file > >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > t/db_dependent/selenium/authentication.t | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/selenium/authentication.t b/t/db_dependent/selenium/authentication.t >index baee58de76..bf39a6e6c2 100755 >--- a/t/db_dependent/selenium/authentication.t >+++ b/t/db_dependent/selenium/authentication.t >@@ -166,7 +166,7 @@ SKIP: { > 'Password field is obscured initially' > ); > >- $driver->find_element('//input[@id="show-password-toggle-checkbox-modal"]')->click; >+ $driver->find_element('//div[@id="loginModal"]//input[@class="show-password-toggle-checkbox"]')->click; > > is( > $driver->find_element('//div[@id="loginModal"]//input[@id="mpassword"]')->get_attribute('type'), >@@ -174,7 +174,7 @@ SKIP: { > 'Password field is shown' > ); > >- $driver->find_element('//input[@id="show-password-toggle-checkbox-modal"]')->click; >+ $driver->find_element('//div[@id="loginModal"]//input[@class="show-password-toggle-checkbox"]')->click; > > $driver->find_element('//div[@id="loginModal"]//input[@type="submit"]')->click; > like( $driver->get_title, qr(Koha online catalog), 'Patron without permission should be able to login to the OPAC using the modal' ); >@@ -214,7 +214,7 @@ SKIP: { > 'Password field is obscured initially' > ); > >- $driver->find_element('//input[@id="show-password-toggle-checkbox-main"]')->click; >+ $driver->find_element('//div[@id="login"]//input[@class="show-password-toggle-checkbox"]')->click; > > is( > $driver->find_element('//div[@id="login"]//input[@id="password"]')->get_attribute('type'), >@@ -222,7 +222,7 @@ SKIP: { > 'Password field is shown' > ); > >- $driver->find_element('//input[@id="show-password-toggle-checkbox-main"]')->click; >+ $driver->find_element('//div[@id="login"]//input[@class="show-password-toggle-checkbox"]')->click; > $s->submit_form; > $driver->find_element('//div[@id="userdetails"]'); > like( $driver->get_title, qr(Your library home), 'Patron without permissions should be able to login to the OPAC using the form on the right'); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34778
:
173115
|
173310
|
174442
|
176485
|
176486
|
176501
|
176502
|
176505
|
176506
|
176703
|
176904
|
176905
|
176907
|
176908
|
176909
|
176910
|
176911
|
177272
|
177300
|
177301
|
177302
|
177303
|
177304
| 177305