Bugzilla – Attachment 177335 Details for
Bug 38998
Cannot edit default SMTP server config when not using DB
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38998: Only show Edit link for DB default SMTP server
Bug-38998-Only-show-Edit-link-for-DB-default-SMTP-.patch (text/plain), 2.19 KB, created by
Magnus Enger
on 2025-01-30 07:54:30 UTC
(
hide
)
Description:
Bug 38998: Only show Edit link for DB default SMTP server
Filename:
MIME Type:
Creator:
Magnus Enger
Created:
2025-01-30 07:54:30 UTC
Size:
2.19 KB
patch
obsolete
>From d14c1a3791bc3dd37ff53ee7535437b40e32fefe Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 30 Jan 2025 05:25:21 +0000 >Subject: [PATCH] Bug 38998: Only show Edit link for DB default SMTP server > >This change only shows the "Edit" on the smtp_servers.pl page >for the "Current default configuratio" if the default >configuration can be edited. That is, don't show it when >config comes from the code, and do show it when the config >comes from the database. > >Test plan: >0. Apply the patch >1. Go to /cgi-bin/koha/admin/smtp_servers.pl >2. Ensure you delete any SMTP servers you've defined >3. Note that there is no "Edit" button at the bottom of >"Current default configuration" >4. Click "New SMTP server" and create a new default server >5. Go to /cgi-bin/koha/admin/smtp_servers.pl >6. Notice how now there is an "Edit" link at the bottom of >"Current default configuration" > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >Followed the test plan, works as advertised. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >index 6fc48a973f..85964e4223 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt >@@ -492,7 +492,7 @@ > <li><span class="label">Timeout (secs): </span> [%- default_config.timeout | html -%]</li> > <li><span class="label">SSL: </span> [%- IF default_config.ssl_mode == 'disabled' -%]<span>Disabled</span>[%- ELSIF default_config.ssl_mode == 'ssl' -%]<span>SSL</span>[%- ELSE -%]<span>STARTTLS</span>[%- END -%]</li> > <li><span class="label">Debug mode: </span> [%- IF default_config.debug -%]Yes[%- ELSE -%]No[%- END -%]</li> >- [% IF op == 'list' %] >+ [% IF op == 'list' && default_config.id %] > <li><a href="/cgi-bin/koha/admin/smtp_servers.pl?op=edit_form&smtp_server_id=[% default_config.id | uri %]"><i class="fa fa-pencil"></i> Edit</a></li> > [% END %] > </ul> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38998
:
177333
|
177335
|
177374