Bugzilla – Attachment 177360 Details for
Bug 38773
SMTP server is not showing on the library detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38773: SMTP server is not showing on the library detail page
Bug-38773-SMTP-server-is-not-showing-on-the-librar.patch (text/plain), 3.06 KB, created by
Owen Leonard
on 2025-01-30 19:33:29 UTC
(
hide
)
Description:
Bug 38773: SMTP server is not showing on the library detail page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2025-01-30 19:33:29 UTC
Size:
3.06 KB
patch
obsolete
>From 4037f7a8fa4506878aa4dd85c5993ca65d97ffff Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 30 Jan 2025 19:29:44 +0000 >Subject: [PATCH] Bug 38773: SMTP server is not showing on the library detail > page > >This patch fixes and incorrect template variable name, making it >possible to see a library's SMTP server when viewing the details of an >individual library. > >Test plan copied from the original bug report: > >1. Create an SMTP server in Koha (it doesn't need to be valid) > a. Go to Administration -> Additional parameters -> SMTP servers > b. Click "New STP server" > c. Fill all mandatory fields (it doesn't need to be valid > information) > d. Click "Submit" > >2. Add the created SMTP server to a library > a. Go to Administration -> Basic parameters -> Libraries > b. Choose a library and click on Edit (in column "Actions") > c. On the line "SMTP server" select the server created > d. Click "Submit" > >3. Check the display > a. Go to Administration -> Basic parameters -> Libraries > b. Check that the name of the SMTP server you just selected is > displayed in the column SMTP server > c. Click on the name of the library you modified > d. Check that the line "SMTP server" shows the correct information. > >4. Test with different permissions > a. If the logged-in user has both 'manage_libraries' and > 'manage_smtp_servers' permissions the SMTP server name should be > liked to the edit form for that server. > b. If the logged-in user has only 'manage_libraries' permission there > should be no link. >--- > .../prog/en/modules/admin/branches.tt | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >index 6c6ef20c66e..59608f71680 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt >@@ -517,10 +517,16 @@ > <span class="label">Return-Path: </span> > [% library.branchreturnpath | html %] > </li> >- <li> >- <span class="label">SMTP server: </span> >- [% smtp_server.name | html %] >- </li> >+ [% IF ( library.smtp_server.id ) %] >+ <li> >+ <span class="label">SMTP server: </span> >+ [% IF ( CAN_user_parameters_manage_smtp_servers ) %] >+ <a href="/cgi-bin/koha/admin/smtp_servers.pl?op=edit_form&smtp_server_id=[% library.smtp_server.id | uri %]">[% library.smtp_server.name | html %]</a> >+ [% ELSE %] >+ [% library.smtp_server.name | html %] >+ [% END %] >+ </li> >+ [% END %] > <li> > <span class="label">URL: </span> > [% IF ( library.branchurl ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38773
:
177360
|
177361
|
177393
|
177394
|
177399