Bugzilla – Attachment 177463 Details for
Bug 39007
Add last_audit to the sushi_service API spec
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39007: Replace warning_like with is
Bug-39007-Replace-warninglike-with-is.patch (text/plain), 1.34 KB, created by
Jonathan Druart
on 2025-02-03 08:50:31 UTC
(
hide
)
Description:
Bug 39007: Replace warning_like with is
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-03 08:50:31 UTC
Size:
1.34 KB
patch
obsolete
>From 6bf946c5008b87b537b19735438b2bd1fc592cd9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Mon, 3 Feb 2025 09:50:18 +0100 >Subject: [PATCH] Bug 39007: Replace warning_like with is > >--- > t/db_dependent/api/v1/erm_sushi_services.t | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/t/db_dependent/api/v1/erm_sushi_services.t b/t/db_dependent/api/v1/erm_sushi_services.t >index 5595d727b0f..7714e85c39f 100755 >--- a/t/db_dependent/api/v1/erm_sushi_services.t >+++ b/t/db_dependent/api/v1/erm_sushi_services.t >@@ -105,11 +105,10 @@ subtest 'get() tests' => sub { > my @response_fields = map { $_ } keys %$sushi_service; > my @new_fields_in_response = array_minus( @response_fields, @expected_fields ); > >- my $new_fields_string = >- "This is not a new error within Koha, the following new field(s) have been added to the API response: " >+ is( scalar(@new_fields_in_response), 0, "Compare response from sushi server" ) >+ or diag "This is not a new error within Koha, the following new field(s) have been added to the API response: " > . join( ', ', @new_fields_in_response ) > . '. They should be added to the API definition'; >- warning_like { scalar(@new_fields_in_response) } 0, $new_fields_string; > > $schema->storage->txn_rollback; > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39007
:
177381
|
177382
|
177390
|
177392
| 177463 |
178004
|
178005
|
178006