Bugzilla – Attachment 177473 Details for
Bug 38986
Restore "Any" option to purchase suggestion filter by fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38986: Restore Any in fund dropdown on suggestions homepage
Bug-38986-Restore-Any-in-fund-dropdown-on-suggesti.patch (text/plain), 1.58 KB, created by
Andrew Fuerste-Henry
on 2025-02-03 18:10:03 UTC
(
hide
)
Description:
Bug 38986: Restore Any in fund dropdown on suggestions homepage
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-02-03 18:10:03 UTC
Size:
1.58 KB
patch
obsolete
>From 3ea58ac246aee6ca4635c676f9b794e581b31e00 Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Mon, 3 Feb 2025 18:07:24 +0000 >Subject: [PATCH] Bug 38986: Restore Any in fund dropdown on suggestions > homepage > >This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion > >To test: >1 - have two suggestions, one with a fund assigned and one without >2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option >3 - apply patch, reload page >4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly >5 - confirm you cannot select Any when creating a new suggestion >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index b5d16d2c7c..6825dddf00 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1287,7 +1287,9 @@ > [% BLOCK funds_dropdown %] > <label for="budgetid">Fund:</label> > <select name="budgetid" id="budgetid"> >- <option value="">Any</option> >+ [% UNLESS op == 'save' %] >+ <option value="">Any</option> >+ [% END %] > [% IF budgetid == '__NONE__' %] > <option value="__NONE__" selected="selected">None</option> > [% ELSE %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38986
:
177282
|
177285
|
177473
|
177474
|
177494