Bugzilla – Attachment 177489 Details for
Bug 39021
Badly formatted dropdown on patron account transactions page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39021: Fix badly formatted dropdown on patron account transactions page
Bug-39021-Fix-badly-formatted-dropdown-on-patron-a.patch (text/plain), 3.37 KB, created by
David Nind
on 2025-02-03 21:50:17 UTC
(
hide
)
Description:
Bug 39021: Fix badly formatted dropdown on patron account transactions page
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-02-03 21:50:17 UTC
Size:
3.37 KB
patch
obsolete
>From fb6c9e235a1609c0330feff37d4730e605757d1d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 28 Jan 2025 12:35:15 +0000 >Subject: [PATCH] Bug 39021: Fix badly formatted dropdown on patron account > transactions page > >This patch makes minor markup changes in order for the "Email" menu item >to be styled correctly after the Bootstrap upgrade. The patch also >simplifies the submission of the form by removing unnecessary JS event >handling. > >To test, apply the patch and locate a patron record to view. > >- Open the "Accounting" tab >- Click "Create manual invoice" >- Put a charge on the patron's account and click "Save and pay" >- Pay the charge >- Click "Transactions" > - In the "Actions" column there should be a "Receipt" menu. > - The "Email" item should be correctly formatted, matching the "Print" > entry. > - Clicking "Email" should result in the page refreshing, with the > message "Receipt sent" at the top. > - If you don't have email set up you can confirm that the message was > queued by creating an SQL report: "SELECT * FROM `message_queue`" > - The report should show the message with the receipt you emailed. > >Sponsored-by: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> >--- > .../prog/en/modules/members/boraccount.tt | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >index 4c325e5f46..a737110edb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt >@@ -137,7 +137,7 @@ > <td class="actions"> > [% IF ( account.is_credit ) %] > [% IF Koha.Preference('UseEmailReceipts') %] >- <div class="btn-group"> >+ <div class="btn-group dropup"> > <button class="btn btn-xs btn-default dropdown-toggle" data-bs-toggle="dropdown" aria-expanded="false"><i class="fa fa-receipt"></i> Receipt</button> > <ul class="dropdown-menu dropdown-menu-end"> > <li><a target="_blank" href="printfeercpt.pl?accountlines_id=[% account.accountlines_id | uri %]" class="receipt-print-action dropdown-item"><i class="fa fa-print"></i> Print</a></li> >@@ -147,8 +147,10 @@ > <input type="hidden" name="op" value="cud-send_receipt" /> > <input type="hidden" name="accountlines_id" value="[% account.accountlines_id | html %]" /> > <input type="hidden" name="borrowernumber" value="[% account.borrowernumber | html %]" /> >+ <button type="submit" class="dropdown-item receipt-email-action"> >+ <i class="fa fa-envelope"></i> Email >+ </button> > </form> >- <a href="#" class="receipt-email-action"><i class="fa fa-envelope"></i> Email</a> > </li> > </ul> > </div> >@@ -475,11 +477,6 @@ > $("#discount").attr({ "value": (0).format_price(), "max": amountoutstanding, "min": 0 }); > $("#discount").focus(); > }); >- >- $(".receipt-email-action").on("click", function(e){ >- e.preventDefault(); >- return $(this).siblings('form').submit(); >- }); > }); > </script> > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39021
:
177475
|
177489
|
177621
|
177919