Bugzilla – Attachment 177505 Details for
Bug 17656
Irregularities in serial prediction pattern are planned only for current subscription
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17656: (QA follow-up) fix compile errors
Bug-17656-QA-follow-up-fix-compile-errors.patch (text/plain), 1.77 KB, created by
Arthur Suzuki
on 2025-02-04 13:14:48 UTC
(
hide
)
Description:
Bug 17656: (QA follow-up) fix compile errors
Filename:
MIME Type:
Creator:
Arthur Suzuki
Created:
2025-02-04 13:14:48 UTC
Size:
1.77 KB
patch
obsolete
>From 13e58c31ebd97f78b62078755fe3387b1c3980d3 Mon Sep 17 00:00:00 2001 >From: Arthur Suzuki <arthur.suzuki@biblibre.com> >Date: Tue, 4 Feb 2025 12:02:27 +0100 >Subject: [PATCH] Bug 17656: (QA follow-up) fix compile errors > >--- > serials/subscription-renew.pl | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > >diff --git a/serials/subscription-renew.pl b/serials/subscription-renew.pl >index d23945aee62..7d7aa343a9b 100755 >--- a/serials/subscription-renew.pl >+++ b/serials/subscription-renew.pl >@@ -88,7 +88,6 @@ if ( $op eq "cud-renew" ) { > print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid"); > } > >- my @permanent_irregularities = $query->param('permanent_irregularity'); > my @irregularities = $query->param('irregularity'); > my $startdate = output_pref( { str => scalar $query->param('startdate'), dateonly => 1, dateformat => 'iso' } ); > ($numberlength, $weeklength, $monthlength) = GetSubscriptionLength( $subtype, $sublength ); >@@ -122,8 +121,9 @@ if ( $op eq "cud-renew" ) { > > $subscription = Koha::Subscriptions->find( $subscriptionid ); > my @irregularities = $subscription->guess_irregularities; >- $subscription->permanent_irregularity(join(';', @permanent_irregularities)); >- $subscription->irregularity( join(';', @irregularities) ) >+ my @permanent_irregularities = $query->param('permanent_irregularity'); >+ $subscription->permanent_irregularity( join(';', @permanent_irregularities) ); >+ $subscription->irregularity( join(';', @irregularities) ); > $subscription->store; > } > } >@@ -193,7 +193,6 @@ else { > > $template->param( > op => $op, >- popup => ($mode eq 'popup'), > ); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17656
:
68259
|
68261
|
68607
|
68608
|
68665
|
69124
|
69207
|
69279
|
69553
|
69814
|
69820
|
69915
|
70335
|
70336
|
70430
|
70619
|
75403
|
75404
|
75405
|
75406
|
75407
|
75408
|
75721
|
75722
|
75723
|
75724
|
75725
|
75726
|
75953
|
102724
|
102725
|
102726
|
102727
|
102728
|
102729
|
102730
|
102860
|
102861
|
102862
|
102863
|
102864
|
102865
|
102866
|
102867
|
102960
|
102961
|
102962
|
102963
|
102964
|
102965
|
102966
|
102967
|
102968
|
103623
|
103624
|
103625
|
103626
|
103627
|
103628
|
103629
|
103630
|
103631
|
103657
|
103658
|
103659
|
103660
|
103661
|
103662
|
103663
|
103664
|
103665
|
103667
|
117789
|
117790
|
117791
|
117792
|
117846
|
117851
|
117852
|
118856
|
119106
|
120863
|
121082
|
121083
|
121084
|
121085
|
121086
|
121087
|
121088
|
121192
|
121193
|
121194
|
121195
|
121196
|
121197
|
121198
|
121296
|
121297
|
121298
|
121299
|
121300
|
121301
|
121302
|
128489
|
128491
|
128492
|
128493
|
128494
|
128495
|
128496
|
128498
|
128499
|
128500
|
128501
|
128502
|
128503
|
128504
|
132412
|
132413
|
132415
|
132416
|
132417
|
132418
|
132447
|
132448
|
132692
|
132779
|
177497
|
177498
|
177499
|
177500
|
177501
|
177502
|
177503
|
177504
| 177505