Bugzilla – Attachment 177557 Details for
Bug 39035
CookieConsentBar message prints on slip when cookies aren’t accepted
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39035: CookieConsentBar message prints on slip when cookies aren’t accepted
Bug-39035-CookieConsentBar-message-prints-on-slip-.patch (text/plain), 2.27 KB, created by
William Lavoie
on 2025-02-05 20:53:52 UTC
(
hide
)
Description:
Bug 39035: CookieConsentBar message prints on slip when cookies aren’t accepted
Filename:
MIME Type:
Creator:
William Lavoie
Created:
2025-02-05 20:53:52 UTC
Size:
2.27 KB
patch
obsolete
>From 5721986d6ad81430d336f495d21c3454f7415fdb Mon Sep 17 00:00:00 2001 >From: William Lavoie <william.lavoie@inLibro.com> >Date: Wed, 5 Feb 2025 15:43:05 -0500 >Subject: [PATCH] =?UTF-8?q?Bug=2039035:=20CookieConsentBar=20message=20pri?= > =?UTF-8?q?nts=20on=20slip=20when=20cookies=20aren=E2=80=99t=20accepted?= >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >I added a print media query in moremember-print.tt to avoid displaying >the cookies when printing a slip. > >Before testing, make sure: > > - set the CookieConsent system preference to enable > - set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) > >Test plan: > >1. Open a different web browser that hasnât accepted Kohaâs cookies yet. >2. Log into the staff interface (do not accept cookies yet). >3. Find a patron account. >4. Click on "Print" and choose any slip. >5. Check the printed slip. > ---> Koha is printing the CookieConsentBar message at the bottom, which shouldnât be there. >6. Now, accept the cookies at the bottom of the screen. >7. Print another slip. >8. Check the new slip. >---> This time, the CookieConsentBar message is gone (as expected). >--- > .../prog/en/modules/members/moremember-print.tt | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >index b31d20322b..e578ffa9f6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt >@@ -16,7 +16,16 @@ > [% t("Koha") | html %] > [% END %]</title> > [% INCLUDE 'doc-head-close.inc' %] >- <style>.pager div.dt-buttons { justify-content: flex-start; }</style> >+ <style>.pager div.dt-buttons { justify-content: flex-start; } >+ @media print{ >+ #cookieConsentBar_content { >+ display: none; >+ } >+ .consentButtons { >+ display: none; >+ } >+ } >+ </style> > </head> > > <body id="pat_moremember-print" class="pat"> >@@ -254,3 +263,5 @@ > [% END %] > > [% INCLUDE 'intranet-bottom.inc' %] >+ >+ >-- >2.43.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39035
:
177557
|
177570
|
177650
|
178698