Bugzilla – Attachment 17766 Details for
Bug 7054
NORMARC: wrong default for 000 position 17
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 7054 - NORMARC: Fix default for 000 position 17
PASSED-QA-Bug-7054---NORMARC-Fix-default-for-000-p.patch (text/plain), 2.52 KB, created by
Katrin Fischer
on 2013-04-28 10:17:52 UTC
(
hide
)
Description:
[PASSED QA] Bug 7054 - NORMARC: Fix default for 000 position 17
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-28 10:17:52 UTC
Size:
2.52 KB
patch
obsolete
>From 92f3adaa4a4b8ddd31a3fd3e72cd9ba4771fd260 Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@enger.priv.no> >Date: Mon, 15 Apr 2013 19:02:46 +0200 >Subject: [PATCH] [PASSED QA] Bug 7054 - NORMARC: Fix default for 000 position > 17 >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Someone at the library education in Oslo told me that it would be >better to have the default for 000/17 set to 1, instead of 2 as it >is today. > >To reproduce: >- Run through the Web-installer in Norwegian and choose NORMARC as > the MARC dialect >- Go to Home > Cataloging > Add MARC record and start to add a new > record >- Click in the 000 field and it should be filled with: > " nam a22 2 4500" >- Reload the page, then open the value builder for 000 and click on OK >- 000 should get filled with the same string as above > >To test: >- Apply the patch and repeat the steps from above. The default value > for 000 should now be: > " nam a22 1 4500" > >(Don't be confused by the 1s and the 2s. A value of 1 in position 17 >means "level 2", and a value of 2 means "level 1" - that is how it >is defined in the "standard": >1 = Nivå 2, iflg. Katalogiseringsregler >2 = Nivå 1, iflg. Katalogiseringsregler) > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Small changes. Didn't test in a NORMARC installaton, but >trusting Magnus with this and seeing no reason why it >shouldn't work. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > cataloguing/value_builder/normarc_leader.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/cataloguing/value_builder/normarc_leader.pl b/cataloguing/value_builder/normarc_leader.pl >index fd29d60..260d346 100755 >--- a/cataloguing/value_builder/normarc_leader.pl >+++ b/cataloguing/value_builder/normarc_leader.pl >@@ -45,7 +45,7 @@ my $res=" > > function Focus$function_name(subfield_managed) { > if(!document.getElementById(\"$field_number\").value){ >- document.getElementById(\"$field_number\").value = ' nam a22 2 4500'; >+ document.getElementById(\"$field_number\").value = ' nam a22 1 4500'; > } > return 1; > } >@@ -81,7 +81,7 @@ my ($template, $loggedinuser, $cookie) > flagsrequired => {editcatalogue => 1}, > debug => 1, > }); >- $result = " nam a22 2 4500" unless $result; >+ $result = " nam a22 1 4500" unless $result; > my $f5 = substr($result,5,1); > my $f6 = substr($result,6,1); > my $f7 = substr($result,7,1); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7054
:
17467
|
17471
|
17762
|
17765
| 17766