Bugzilla – Attachment 177661 Details for
Bug 39032
"Items selected" in item search untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39032: "Items selected" in item search untranslatable
Bug-39032-Items-selected-in-item-search-untranslat.patch (text/plain), 2.57 KB, created by
David Nind
on 2025-02-08 19:49:28 UTC
(
hide
)
Description:
Bug 39032: "Items selected" in item search untranslatable
Filename:
MIME Type:
Creator:
David Nind
Created:
2025-02-08 19:49:28 UTC
Size:
2.57 KB
patch
obsolete
>From b50837892a27b45fb40c6c6ae12c016848718b3b Mon Sep 17 00:00:00 2001 >From: caroline <caroline@inlibro.com> >Date: Tue, 4 Feb 2025 15:29:13 -0500 >Subject: [PATCH] Bug 39032: "Items selected" in item search untranslatable > >This patch corrects a syntax error that prevented the string >"Items selected" from being picked up by the translation tool. > >To recreate: > >1. Go to Item search > >2. Click 'Search' > >3. Select one or more results > --> In the bar at the top of the results there is a rectangle with "Items selected: N XClear" > >4. Install another language (e.g. fr-CA) > 4.1. For ktd, do the following commands > > ktd --shell > gulp po:update --lang fr-CA > > Ctrl+D (exit shell) > > ktd --root --shell > koha-translate --install fr-CA --dev kohadev > koha-translate --update fr-CA --dev kohadev > > 4.2. Go to Administration > System preferences > 4.3. Search for StaffInterfaceLanguages > 4.4. Check fr-CA > 4.5. Click 'Save all I18N/L10N preferences' > >5. Redo steps 1-3 in French > --> "Items selected" is not translated > >6. Apply patch > >7. Update translations > (for ktd) > ktd --shell > gulp po:update --lang fr-CA > >8. Open misc/translator/po/fr-CA-staff-prog.po > >9. Search for "Items selected" > --> It should be there, with a fuzzy flag > >10. Translate the phrase in msgstr and remove the line with the fuzzy flag > >11. Apply translations > (for ktd) > ktd --root --shell > koha-translate --update fr-CA --dev kohadev > >12. Redo steps 1-3 in French > --> "Items selected" is now translated! > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >index 01e12c6a14..fb640df5d9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt >@@ -370,7 +370,7 @@ > function showItemSelections( number ){ > let caret = ' <span class="caret">'; > if( number > 0 ){ >- $("#table_search_selections").show().find("span").text(_("Items selected: " + number ) ); >+ $("#table_search_selections").show().find("span").html(_("Items selected: ") + number ); > $("#batch_mod_menu").removeClass("disabled").prop("disabled", false); > $("#export-button").html(_("Export selected results (%s) to").format ( number ) + caret); > } else { >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39032
:
177517
|
177661
|
178085