Bugzilla – Attachment 17772 Details for
Bug 7055
NORMARC: Links and defaults for 008 position 15-17 and 35-37
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37
PASSED-QA-Bug-7055---NORMARC-Fix-008-position-15-1.patch (text/plain), 6.33 KB, created by
Katrin Fischer
on 2013-04-28 13:32:41 UTC
(
hide
)
Description:
[PASSED QA] Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2013-04-28 13:32:41 UTC
Size:
6.33 KB
patch
obsolete
>From b756387f545ea39229d5eb03e44e81173ae49024 Mon Sep 17 00:00:00 2001 >From: Magnus Enger <magnus@enger.priv.no> >Date: Mon, 15 Apr 2013 19:50:19 +0200 >Subject: [PATCH] [PASSED QA] Bug 7055 - NORMARC: Fix 008 position 15-17 and > 35-37 > >This patch does several things: >- Set the default for 008/15-17 to "no " (yes, there is space at the end) >- Link from 008/15-17 in the value builder to NORMARC country codes >- Set the default for 008/35-37 to "nor" (by setting the > DefaultLanguageField008 syspref) >- Link from 008/35-37 in the value builder to NORMARC language codes >- Fix a missing <tr> around field 35-37 > >To reproduce: >- Run through the Web-installer in Norwegian and choose NORMARC as > the MARC flavour >- Go to Home > Cataloging > Add MARC record and add a new record >- Click in the field for 008. The default should look like: > 130415t xxu||||| |||| 00| 0 eng d > ^^^ ^^^ >- Reload the page and open the value builder for 008. Problems: > - The text for 15-17 links to MARC21 country codes > - The default for 15-17 is xxu > - The text for 35-37 links to MARC21 language codes > - The default for 35-37 is eng > - If you choose e.g. "Monografier" in the top dropdown then click > on "OK" the window does not close > >To test: >- Apply the patch and run through the Web-installer again, selecting > Norwegian and NORMARC >- Go to Home > Cataloging > Add MARC record and add a new record >- Click in the field for 008. The default should look like: > 130415t no ||||| |||| 00| 0 nor d > ^^^ ^^^ >- Reload the page and open the value builder for 008. >- Check that... > - The default for 15-17 is "no " (with a space at the end) > - The link goes to NORMARC country codes > - The default for 35-37 is "nor" > - The link goes to NORMARC language codes >- Select something from the top dropdown and click "OK". Check that the > window closes and that the values that are entered into the 008 field > matches what you chose in the popup window. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > >Trusing Magnus is right, so testing for any regressions mainly, all good > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Only changes NORMARC specific plugin and system preferences >files. Changes all seem logical to me. >--- > cataloguing/value_builder/normarc_field_008.pl | 4 ++-- > .../nb-NO/1-Obligatorisk/system_preferences.sql | 1 + > .../cataloguing/value_builder/normarc_field_008.tt | 7 ++++--- > 3 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/cataloguing/value_builder/normarc_field_008.pl b/cataloguing/value_builder/normarc_field_008.pl >index 5efe9a8..98ca163 100755 >--- a/cataloguing/value_builder/normarc_field_008.pl >+++ b/cataloguing/value_builder/normarc_field_008.pl >@@ -58,7 +58,7 @@ function Focus$function_name(subfield_managed) { > if ( document.getElementById(\"$field_number\").value ) { > } > else { >- document.getElementById(\"$field_number\").value='$dateentered' + 't xxu||||| |||| 00| 0 $lang d'; >+ document.getElementById(\"$field_number\").value='$dateentered' + 't no ||||| |||| 00| 0 $lang d'; > } > return 1; > } >@@ -101,7 +101,7 @@ sub plugin { > ); > > # $result = " t xxu 00 0 eng d" unless $result; >- $result = "$dateentered" . "t xxu||||| |||| 00| 0 $lang d" unless $result; >+ $result = "$dateentered" . "t no ||||| |||| 00| 0 $lang d" unless $result; > my $f1 = substr($result, 0, 6); > my $f6 = substr($result, 6, 1); > my $f710 = substr($result, 7, 4); >diff --git a/installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql b/installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql >index c605944..eeedc86 100644 >--- a/installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql >+++ b/installer/data/mysql/nb-NO/1-Obligatorisk/system_preferences.sql >@@ -28,3 +28,4 @@ UPDATE systempreferences SET value = '<p>Viktige lenker kan plasseres her</p>' W > UPDATE systempreferences SET value = '<li><a href="http://worldcat.org/search?q={TITLE}" target="_blank">Andre bibliotek (WorldCat)</a></li><li><a href="http://www.scholar.google.com/scholar?q={TITLE}" target="_blank">Andre databaser (Google Scholar)</a></li><li><a href="http://www.bookfinder.com/search/?author={AUTHOR}&title={TITLE}&st=xl&ac=qr" target="_blank">Nettbutikker (Bookfinder.com)</a></li>' WHERE variable = 'OPACSearchForTitleIn'; > UPDATE systempreferences SET value = 'Monday' WHERE variable = 'CalendarFirstDayOfWeek'; > UPDATE systempreferences SET value = 'A B C D E F G H I J K L M N O P Q R S T U V W X Y Z à à Ã' WHERE variable = 'alphabet'; >+UPDATE systempreferences SET value = 'nor' WHERE variable = 'DefaultLanguageField008'; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/normarc_field_008.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/normarc_field_008.tt >index cfdba9c..14101b1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/normarc_field_008.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/normarc_field_008.tt >@@ -128,9 +128,9 @@ > </tr> > > <tr> >- <td><label for="f1517">15-17 Utgivelsesland</label> See <a href="http://www.loc.gov/marc/countries/countries_code.html">MARC Code List for Countries</a> </td> >+ <td><label for="f1517">15-17 Utgivelsesland</label> (Se <a href="http://www.nb.no/baser/landekoder/">NORMARC-koder for land</a>)</td> > <td> >- <input type="text" name="f1517" id="f1517" size="3" maxlength="3" value="[% f1517 %]"/> >+ <input type="text" name="f1517" id="f1517" size="3" maxlength="3" value="[% f1517 %]"/> <!-- Default is set by the DefaultLanguageField008 syspref --> > </td> > </tr> > >@@ -139,7 +139,8 @@ > <tr><td id="choices" colspan="2"></td></tr> > > <!-- Start second batch of common fields for all formats --> >- <td><label for="f3537">35-37 SprÃ¥k</label> See <a href="http://www.loc.gov/marc/languages/language_code.html">MARC Code List for Languages</a></td> >+ <tr> >+ <td><label for="f3537">35-37 SprÃ¥k</label> (Se <a href="http://www.nb.no/baser/sprakkoder/">NORMARC-koder for sprÃ¥k</a>)</td> > <td> > <input type="text" name="f3537" id="f3537" size="4" maxlength="4" value="[% f3537 %]"/> > </td> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7055
:
17468
|
17470
|
17763
| 17772