Bugzilla – Attachment 177721 Details for
Bug 30975
Use event delegation for framework plugins to avoid using private jQuery method _data
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 30975: Fix upload plugin
Bug-30975-Fix-upload-plugin.patch (text/plain), 1.45 KB, created by
David Cook
on 2025-02-11 00:19:16 UTC
(
hide
)
Description:
Bug 30975: Fix upload plugin
Filename:
MIME Type:
Creator:
David Cook
Created:
2025-02-11 00:19:16 UTC
Size:
1.45 KB
patch
obsolete
>From 5965ac48fb17e21af14e7841923f888eeef55cdf Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Fri, 13 Dec 2024 09:21:10 +0100 >Subject: [PATCH] Bug 30975: Fix upload plugin > >The upload plugin button has no 'buttonDot' class (unlike other plugins >buttons) so its click event were not listened to. >This patch fix the CSS selector in order to listen on click events for >all plugins buttons > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: David Cook <dcook@prosentient.com.au> >--- > koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >index 1e6b87a4d3..43613ec420 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js >@@ -642,6 +642,6 @@ $(document).ready(function() { > // We use delegated event handlers here so that dynamically added elements > // (like when cloning a field or a subfield) respond to these events > // without having to re-attach events manually >- $('.marc_editor').on('click', '.buttonDot', callClickPluginEventHandler); >+ $('.marc_editor').on('click', '.tag_editor.framework_plugin', callClickPluginEventHandler); > $('.marc_editor').on('focusin focusout change mousedown mouseup keydown keyup', 'input.input_marceditor.framework_plugin', callPluginEventHandler); > }); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 30975
:
136135
|
138318
|
140763
|
140810
|
146146
|
146817
|
158064
|
170499
|
170500
|
171513
|
171514
|
175432
|
175433
|
175434
|
175435
|
175436
|
175437
|
177612
|
177613
|
177614
|
177615
|
177616
|
177719
|
177720
| 177721 |
177722
|
177723