Bugzilla – Attachment 177806 Details for
Bug 35635
Expand patron attribute type mandatory field to allow different settings for OPAC and staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35635: Add opac_mandatory to patron attribute table
Bug-35635-Add-opacmandatory-to-patron-attribute-ta.patch (text/plain), 3.57 KB, created by
Lucas Gass (lukeg)
on 2025-02-11 21:41:12 UTC
(
hide
)
Description:
Bug 35635: Add opac_mandatory to patron attribute table
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-02-11 21:41:12 UTC
Size:
3.57 KB
patch
obsolete
>From 39131de46a97a01fdfa636e7058a5273a03c196b Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 6 Jun 2024 13:26:54 +0000 >Subject: [PATCH] Bug 35635: Add opac_mandatory to patron attribute table > >To test: >1. Before applying the patch go to Adminstration > Patron attribute types >2. Create or modify some attributes to be mandatory and some to not be mandatory. >3. APPLY PATCH, updatedatabase, restart_all >4. Go back to Adminstration > Patron attribute types. The patron attributes that were made mandatory should now also have the opac_mandatory field checked. >5. Make sure that you can change the correctly save the new "OPAC mandatory:" field. >6. If the 'Display in OPAC:' field is unchecked the 'OPAC mandatory:' checkbox should be disabled. >7. Mark some patron attributes as 'OPAC mandatory:'. >8. Go to the OPAC self reg page, the field should be required. >9. BAck on Adminstration > Patron attribute types check some attributes as 'OPAC mandatory:' and 'Editable in OPAC:'. >10. As a logged in OPAC user go to "Personal details" and make sure the attribute is required. >11. For the same attriubute as step 9-10 , mark as NOT 'Editable in OPAC:'. Make sure you can still save the form on the OPAC "Personal details" page. > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/admin/patron-attr-types.tt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >index f2984b07d9b..836c6b59821 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt >@@ -328,6 +328,7 @@ > <th>Library limitation</th> > <th>Authorized value category</th> > <th>Mandatory</th> >+ <th>Mandatory - OPAC</th> > <th>Searching</th> > <th class="NoSort noExport">Actions</th> > </tr> >@@ -369,6 +370,13 @@ > <span>No</span> > [% END %] > </td> >+ <td> >+ [% IF ( item.opac_mandatory ) -%] >+ <span>Yes</span> >+ [% ELSE -%] >+ <span>No</span> >+ [% END %] >+ </td> > <td> > [% IF ( item.staff_searchable ) %] > [% IF( item.searched_by_default ) %] >@@ -424,8 +432,10 @@ > .change(function () { > if (this.checked) { > $("#opac_editable").removeAttr("disabled").parent().removeAttr("aria-disabled"); >+ $("#opac_mandatory").removeAttr("disabled").parent().removeAttr("aria-disabled"); > } else { > $("#opac_editable").attr("disabled", true).parent().attr("aria-disabled", "true"); >+ $("#opac_mandatory").attr("disabled", true).parent().attr("aria-disabled", "true"); > } > }) > .change(); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35635
:
167500
|
167501
|
167502
|
167546
|
167548
|
167643
|
167644
|
167645
|
167646
|
174962
|
175059
|
175635
|
175858
|
176595
|
176596
|
176597
|
176598
|
176599
|
176600
|
176601
|
176602
|
176603
|
176604
|
177803
|
177804
|
177805
|
177806
|
177807
|
177808
|
177809
|
177810
|
177811
|
177812
|
177814
|
177815
|
177816
|
177817
|
177818
|
177819
|
177820
|
177821
|
177822
|
177823
|
179165