Bugzilla – Attachment 177833 Details for
Bug 17656
Irregularities in serial prediction pattern are planned only for current subscription
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17656: QA warnings fixes
Bug-17656-QA-warnings-fixes.patch (text/plain), 1.69 KB, created by
Jonathan Druart
on 2025-02-12 10:42:08 UTC
(
hide
)
Description:
Bug 17656: QA warnings fixes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-12 10:42:08 UTC
Size:
1.69 KB
patch
obsolete
>From 95826a5b620af1cf1c57c6dd23f0b489dbe9b551 Mon Sep 17 00:00:00 2001 >From: Alex Arnaud <alex.arnaud@biblibre.com> >Date: Fri, 5 Mar 2021 14:22:53 +0100 >Subject: [PATCH] Bug 17656: QA warnings fixes > >Signed-off-by: Amarangi <amarangikarunathilaka@gmail.com> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/Subscription.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/Koha/Subscription.pm b/Koha/Subscription.pm >index 0ad06feacce..f6fa74c5c48 100644 >--- a/Koha/Subscription.pm >+++ b/Koha/Subscription.pm >@@ -20,7 +20,6 @@ package Koha::Subscription; > use Modern::Perl; > > use C4::Serials::Frequency; >-use C4::Serials qw(issue_number); > > use Koha::Database; > use Koha::Biblios; >@@ -263,7 +262,7 @@ sub guess_irregularities { > my $date = $nextexpected->{planneddate}; > > my ($issuenumber) = C4::Serials::GetFictiveIssueNumber( $self->unblessed, $date ); >- my $dow = issue_number( dt_from_string($date), $frequency->unit ); >+ my $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit ); > > if ( defined( $permanent_irregularities{$dow} ) ) { > push @irregularities, $issuenumber; >@@ -272,7 +271,7 @@ sub guess_irregularities { > while ( Delta_Days( split( /-/, $date ), split( /-/, $enddate ) ) >= 0 ) { > $issuenumber++; > $date = C4::Serials::GetNextDate( $self->unblessed, $date ); >- $dow = issue_number( dt_from_string($date), $frequency->unit ); >+ $dow = C4::Serials::issue_number( dt_from_string($date), $frequency->unit ); > > if ( defined( $permanent_irregularities{$dow} ) ) { > push @irregularities, $issuenumber; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17656
:
68259
|
68261
|
68607
|
68608
|
68665
|
69124
|
69207
|
69279
|
69553
|
69814
|
69820
|
69915
|
70335
|
70336
|
70430
|
70619
|
75403
|
75404
|
75405
|
75406
|
75407
|
75408
|
75721
|
75722
|
75723
|
75724
|
75725
|
75726
|
75953
|
102724
|
102725
|
102726
|
102727
|
102728
|
102729
|
102730
|
102860
|
102861
|
102862
|
102863
|
102864
|
102865
|
102866
|
102867
|
102960
|
102961
|
102962
|
102963
|
102964
|
102965
|
102966
|
102967
|
102968
|
103623
|
103624
|
103625
|
103626
|
103627
|
103628
|
103629
|
103630
|
103631
|
103657
|
103658
|
103659
|
103660
|
103661
|
103662
|
103663
|
103664
|
103665
|
103667
|
117789
|
117790
|
117791
|
117792
|
117846
|
117851
|
117852
|
118856
|
119106
|
120863
|
121082
|
121083
|
121084
|
121085
|
121086
|
121087
|
121088
|
121192
|
121193
|
121194
|
121195
|
121196
|
121197
|
121198
|
121296
|
121297
|
121298
|
121299
|
121300
|
121301
|
121302
|
128489
|
128491
|
128492
|
128493
|
128494
|
128495
|
128496
|
128498
|
128499
|
128500
|
128501
|
128502
|
128503
|
128504
|
132412
|
132413
|
132415
|
132416
|
132417
|
132418
|
132447
|
132448
|
132692
|
132779
|
177497
|
177498
|
177499
|
177500
|
177501
|
177502
|
177503
|
177504
|
177505
|
177663
|
177664
|
177665
|
177666
|
177667
|
177668
|
177669
|
177670
|
177671
|
177831
|
177832
| 177833 |
177834
|
177835
|
177836
|
177837
|
177838
|
177839
|
178142