Bugzilla – Attachment 177908 Details for
Bug 31391
Staff-side recalls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 31391: Test fixes
Bug-31391-Test-fixes.patch (text/plain), 2.73 KB, created by
Jonathan Druart
on 2025-02-12 13:57:35 UTC
(
hide
)
Description:
Bug 31391: Test fixes
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-12 13:57:35 UTC
Size:
2.73 KB
patch
obsolete
>From 5dce773e89a683e54cb8fe34ac7919e61a592adc Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Thu, 9 Nov 2023 02:25:34 +0000 >Subject: [PATCH] Bug 31391: Test fixes > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../intranet-tmpl/prog/en/modules/recalls/request.tt | 2 +- > t/db_dependent/Holds.t | 9 ++++++--- > 2 files changed, 7 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt >index 00a25cb1b91..cf7ca499227 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/recalls/request.tt >@@ -53,7 +53,7 @@ > [% END %] > > [% IF patron_holds_count %] >- <div class="dialog alert alert-info"> Patron has placed one or more record-level holds. <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber | html %]">Convert a hold to a recall</a>. </div> >+ <div class="dialog alert alert-info"> Patron has placed one or more record-level holds. <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio.biblionumber | uri %]">Convert a hold to a recall</a>. </div> > [% END %] > > <fieldset class="rows"> >diff --git a/t/db_dependent/Holds.t b/t/db_dependent/Holds.t >index 2445ce88cc6..b1baba479c9 100755 >--- a/t/db_dependent/Holds.t >+++ b/t/db_dependent/Holds.t >@@ -7,7 +7,7 @@ use t::lib::TestBuilder; > > use C4::Context; > >-use Test::More tests => 72; >+use Test::More tests => 73; > use Test::Exception; > > use MARC::Record; >@@ -2117,7 +2117,10 @@ subtest 'ModReserve to convert a hold to a recall' => sub { > my $category = $builder->build( { source => 'Category' } ); > my $branch = $builder->build( { source => 'Branch' } )->{branchcode}; > my $biblio = $builder->build_sample_biblio( { itemtype => 'DUMMY' } ); >- my $item = $builder->build_sample_item( { library => $branch, biblionumber => $biblio->biblionumber } ); >+ my $itype = $builder->build( { source => 'Itemtype' } ); >+ my $item = >+ $builder->build_sample_item( >+ { library => $branch, biblionumber => $biblio->biblionumber, itype => $itype->{itemtype} } ); > > my $patron = Koha::Patron->new( > { >@@ -2143,7 +2146,7 @@ subtest 'ModReserve to convert a hold to a recall' => sub { > t::lib::Mocks::mock_preference( "UseRecalls", 1 ); > t::lib::Mocks::mock_userenv( { branchcode => $branch } ); > >- C4::Circulation::AddIssue( $patron2->unblessed, $item->barcode ); >+ C4::Circulation::AddIssue( $patron2, $item->barcode ); > > Koha::CirculationRules->set_rules( > { >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 31391
:
139442
|
139443
|
139444
|
139446
|
139642
|
139643
|
139644
|
139645
|
141474
|
142594
|
143155
|
144104
|
144105
|
144131
|
144132
|
144133
|
144134
|
144135
|
144136
|
147581
|
147582
|
150485
|
150486
|
150487
|
150488
|
150489
|
150490
|
150491
|
156995
|
156996
|
156997
|
156998
|
156999
|
157000
|
157001
|
158691
|
158692
|
158693
|
158694
|
158695
|
158825
|
158826
|
158827
|
158828
|
158829
|
158830
|
158831
|
158832
|
172166
|
172167
|
172168
|
172169
|
172170
|
172171
|
172172
|
172173
|
172174
|
172175
|
173839
|
173840
|
173841
|
173842
|
173843
|
173844
|
173845
|
173846
|
173847
|
174396
|
174822
|
174823
|
174824
|
174825
|
174826
|
174827
|
174828
|
174829
|
174830
|
174831
|
177901
|
177902
|
177903
|
177904
|
177905
|
177906
|
177907
| 177908 |
177909
|
177910