Bugzilla – Attachment 177915 Details for
Bug 39089
Delivery note in patron notice table is confusing when the delivery method is print
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39089: Do not show an email address when the tranport type is print
Bug-39089-Do-not-show-an-email-address-when-the-tr.patch (text/plain), 1.97 KB, created by
Jonathan Druart
on 2025-02-12 14:03:24 UTC
(
hide
)
Description:
Bug 39089: Do not show an email address when the tranport type is print
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-12 14:03:24 UTC
Size:
1.97 KB
patch
obsolete
>From 940e3de9b35225b62fef570be96da89c2681334e Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 11 Feb 2025 00:10:24 +0000 >Subject: [PATCH] Bug 39089: Do not show an email address when the tranport > type is print > >To test: >1. Set a overdue trigger for print notice >2. Set up an overdue to be captured by overdue_notices.pl >3. Make sure the patron has an email address >4. Run overdue_notices.pl >5. Run gather_print_notices.pl >6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) >7. Find the print row for the overdue just generated. >8. See that under the 'Delivery note' it says "To: test@test.com". >9. APPLY PATCH >10. Try again, you should now see no "To:" field when the transport type is print >11. Make sure that when the transport type is anything but print, you do see it. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >index 1cacdb14ab4..7665ae3bae4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt >@@ -140,7 +140,7 @@ > [% IF ( QUEUED_MESSAGE.from_address ) %] > <span class="clearfix"><span class="label">From:</span> [% QUEUED_MESSAGE.from_address | html %]</span> > [% END %] >- [% IF ( QUEUED_MESSAGE.to_address ) %] >+ [% IF ( QUEUED_MESSAGE.to_address && QUEUED_MESSAGE.message_transport_type != 'print') %] > <span class="clearfix"><span class="label">To:</span> [% QUEUED_MESSAGE.to_address | html %]</span> > [% END %] > [% IF ( QUEUED_MESSAGE.cc_address ) %] >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39089
:
177718
|
177915
|
179919
|
180032
|
180033