Bugzilla – Attachment 177924 Details for
Bug 38952
JS function messenger not used in acq.js
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38952: Remove JS function messenger from acq.js
Bug-38952-Remove-JS-function-messenger-from-acqjs.patch (text/plain), 2.38 KB, created by
Jonathan Druart
on 2025-02-12 14:37:45 UTC
(
hide
)
Description:
Bug 38952: Remove JS function messenger from acq.js
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-12 14:37:45 UTC
Size:
2.38 KB
patch
obsolete
>From 1a5d3711e0c6be0c3666de5f82cd4268540c9b5d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jan 2025 09:35:27 +0100 >Subject: [PATCH] Bug 38952: Remove JS function messenger from acq.js > >Test plan: >% git grep -l messenger >koha-tmpl/intranet-tmpl/lib/fontawesome/css/brands.min.css >koha-tmpl/intranet-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf >koha-tmpl/opac-tmpl/lib/fontawesome/css/brands.min.css >koha-tmpl/opac-tmpl/lib/fontawesome/webfonts/fa-brands-400.ttf > >The function is unused and can be removed. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> >--- > koha-tmpl/intranet-tmpl/prog/js/acq.js | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/acq.js b/koha-tmpl/intranet-tmpl/prog/js/acq.js >index 760e9e1daea..c69703da4a2 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/acq.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/acq.js >@@ -1,5 +1,5 @@ > /* global confirmDelete */ >-/* exported uncheckbox isNotNull isNull isNum log calcTotalRow autoFillRow messenger updateCosts calcNewsuggTotal getAuthValueDropbox totalExceedsBudget budgetExceedsParent checkBudgetParent hideColumn showColumn showAllColumns hideAllColumns */ >+/* exported uncheckbox isNotNull isNull isNum log calcTotalRow autoFillRow updateCosts calcNewsuggTotal getAuthValueDropbox totalExceedsBudget budgetExceedsParent checkBudgetParent hideColumn showColumn showAllColumns hideAllColumns */ > > //======================================================================= > //input validation: >@@ -172,25 +172,6 @@ function autoFillRow(bud_id) { > remainingTotal.style.color = "black"; > } > >-function messenger(X, Y, etc) { >- // FIXME: unused? >- win = window.open( >- "", >- "mess", >- "height=" + X + ",width=" + Y + ",screenX=150,screenY=0" >- ); >- win.focus(); >- win.document.close(); >- win.document.write( >- "<body link='#333333' bgcolor='#ffffff' text='#000000'><font size='2'><p><br />" >- ); >- win.document.write(etc); >- win.document.write( >- "<center><form><input type=button onclick='self.close()' value='Close'></form></center>" >- ); >- win.document.write("</font></body></html>"); >-} >- > //======================================================================= > > // NEXT BLOCK IS USED BY NEWORDERBEMPTY >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38952
:
176942
|
177067
|
177368
| 177924