Bugzilla – Attachment 177964 Details for
Bug 36135
Add tool to batch modify holds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36135: (follow-up) Adjust for CSRF
Bug-36135-follow-up-Adjust-for-CSRF.patch (text/plain), 3.98 KB, created by
Lucas Gass (lukeg)
on 2025-02-12 18:29:04 UTC
(
hide
)
Description:
Bug 36135: (follow-up) Adjust for CSRF
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2025-02-12 18:29:04 UTC
Size:
3.98 KB
patch
obsolete
>From f8fff17ec83f1df9ed0bd9b36b15fce40505a108 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 20 Mar 2024 14:14:31 +0000 >Subject: [PATCH] Bug 36135: (follow-up) Adjust for CSRF > >Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 2 +- > .../prog/en/modules/tools/batch_modify_holds.tt | 5 +++-- > tools/batch_modify_holds.pl | 2 +- > 3 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 85117a42f66..feab77e9608 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -1067,7 +1067,7 @@ > > > </form> > >- <form method="POST" action="/cgi-bin/koha/tools/batch_modify_holds.pl" id="batch_modify_holds"> >+ <form method="get" action="/cgi-bin/koha/tools/batch_modify_holds.pl" id="batch_modify_holds"> > <input type="hidden" name="op" value="list" /> > [% FOREACH result IN results %] > [% FOREACH cells IN result.cells %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >index 7705c36beb1..2b7220a5ee8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_modify_holds.tt >@@ -42,7 +42,7 @@ > <h1>Batch modify holds</h1> > > [% IF view == 'form' %] >- <form method="post" action="/cgi-bin/koha/tools/batch_modify_holds.pl" id="modify_holds_form"> >+ <form method="get" action="/cgi-bin/koha/tools/batch_modify_holds.pl" id="modify_holds_form"> > <fieldset class="rows"> > <legend>Hold search criteria:</legend> > <span class="hint">NOTE! Column patron_expiration_date is used as a main filter for expiration date field. Otherwise column expirationdate is used.</span> >@@ -106,6 +106,7 @@ > </form> <!-- /#modify_holds_form --> > [% ELSIF view == 'list' %] > <form action="/cgi-bin/koha/tools/batch_modify_holds.pl" method="post" id="process"> >+ [% INCLUDE 'csrf-token.inc' %] > [% IF holds.count %] > <div class="page-section"> > <div class="btn-toolbar selections-toolbar"> >@@ -189,7 +190,7 @@ > </tbody> > </table> <!-- /#hold_modifies --> > <fieldset class="action"> >- <input type="hidden" name="op" value="modify"/> >+ <input type="hidden" name="op" value="cud-modify"/> > <input type="submit" class="btn btn-primary" value="Modify selected holds"/> > <a class="cancel" href="/cgi-bin/koha/tools/batch_modify_holds.pl">Cancel</a> > </fieldset> >diff --git a/tools/batch_modify_holds.pl b/tools/batch_modify_holds.pl >index af37d5500ed..b69b8dd80ac 100644 >--- a/tools/batch_modify_holds.pl >+++ b/tools/batch_modify_holds.pl >@@ -126,7 +126,7 @@ if ( $op eq 'form' ) { > ); > } > >-if ( $op eq 'modify' ) { >+if ( $op eq 'cud-modify' ) { > > my $new_expiration_date = $input->param('new_expiration_date'); > my $new_pickup_loc = $input->param('new_pickup_loc'); >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36135
:
163021
|
163022
|
163023
|
163024
|
163529
|
163530
|
163540
|
163541
|
163542
|
163543
|
163544
|
163796
|
164037
|
164051
|
164057
|
164058
|
164059
|
164060
|
164061
|
164062
|
164063
|
177518
|
177519
|
177959
|
177960
|
177961
|
177962
|
177963
|
177964
|
177965
|
177966
|
177967
|
177968
|
177969
|
177975
|
177976
|
177981
|
177982
|
178154
|
178155
|
178156
|
178157
|
178158
|
178159
|
178160
|
178161
|
178162
|
178163
|
178164
|
178165
|
178166
|
178167