Bugzilla – Attachment 177983 Details for
Bug 39119
xt/js_tidy.t and xt/vue_tidy.t does not use tidy.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39119: Make js_tidy and vue_tidy test use the tidy script
Bug-39119-Make-jstidy-and-vuetidy-test-use-the-tid.patch (text/plain), 1.38 KB, created by
Jonathan Druart
on 2025-02-13 08:21:32 UTC
(
hide
)
Description:
Bug 39119: Make js_tidy and vue_tidy test use the tidy script
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-13 08:21:32 UTC
Size:
1.38 KB
patch
obsolete
>From 7b9c3cbcaae267bb9eb109dc0829c68bb3e430e8 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 13 Feb 2025 09:18:49 +0100 >Subject: [PATCH] Bug 39119: Make js_tidy and vue_tidy test use the tidy script > >They were still using prettier directly. They should use the tidy.pl as >it is doing some wrapper work. >--- > xt/js_tidy.t | 2 +- > xt/vue_tidy.t | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/xt/js_tidy.t b/xt/js_tidy.t >index 3cfedd1dca5..d2deb045029 100755 >--- a/xt/js_tidy.t >+++ b/xt/js_tidy.t >@@ -26,7 +26,7 @@ plan tests => scalar @js_files; > > foreach my $filepath (@js_files) { > chomp $filepath; >- my $tidy = qx{yarn --silent run prettier $filepath}; >+ my $tidy = qx{perl misc/devel/tidy.pl --silent --no-write $filepath}; > my $content = read_file $filepath; > ok( $content eq $tidy, "$filepath should be kept tidy" ); > } >diff --git a/xt/vue_tidy.t b/xt/vue_tidy.t >index 3b16c4b0038..03ab5033088 100755 >--- a/xt/vue_tidy.t >+++ b/xt/vue_tidy.t >@@ -25,7 +25,7 @@ plan tests => scalar @vue_files; > > foreach my $filepath (@vue_files) { > chomp $filepath; >- my $tidy = qx{yarn --silent run prettier $filepath}; >+ my $tidy = qx{perl misc/devel/tidy.pl --silent --no-write $filepath}; > my $content = read_file $filepath; > ok( $content eq $tidy, "$filepath should be kept tidy" ); > } >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39119
:
177983
|
177987
|
178025