Bugzilla – Attachment 178004 Details for
Bug 39007
Add last_audit to the sushi_service API spec
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 39007: [24.05] Update API spec and unit test
Bug-39007-2405-Update-API-spec-and-unit-test.patch (text/plain), 3.04 KB, created by
Jonathan Druart
on 2025-02-13 13:20:08 UTC
(
hide
)
Description:
Bug 39007: [24.05] Update API spec and unit test
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2025-02-13 13:20:08 UTC
Size:
3.04 KB
patch
obsolete
>From ad25cc4bf6228e339e4d6b72fab7bb2654ee2848 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Fri, 31 Jan 2025 13:14:24 +0000 >Subject: [PATCH] Bug 39007: [24.05] Update API spec and unit test > >Test plan: >1) Run prove t/db_dependent/api/v1/erm_sushi_services.t - FAIL >2) Apply patch >3) Repeat step 1 - PASS >4) Inspect patch diff and note that last_audit has been added to the API definition > >Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> > > Please enter the commit message for your changes. Lines starting >--- > api/v1/swagger/definitions/erm_sushi_service.yaml | 3 +++ > t/db_dependent/api/v1/erm_sushi_services.t | 13 ++++++++++++- > 2 files changed, 15 insertions(+), 1 deletion(-) > >diff --git a/api/v1/swagger/definitions/erm_sushi_service.yaml b/api/v1/swagger/definitions/erm_sushi_service.yaml >index 64d9452ea90..bd2988b9ec6 100644 >--- a/api/v1/swagger/definitions/erm_sushi_service.yaml >+++ b/api/v1/swagger/definitions/erm_sushi_service.yaml >@@ -114,6 +114,9 @@ properties: > type: array > items: > type: object >+ last_audit: >+ description: the last time the service was audited >+ type: object > > additionalProperties: false > >diff --git a/t/db_dependent/api/v1/erm_sushi_services.t b/t/db_dependent/api/v1/erm_sushi_services.t >index 097dfc7f73a..b8ead94a151 100755 >--- a/t/db_dependent/api/v1/erm_sushi_services.t >+++ b/t/db_dependent/api/v1/erm_sushi_services.t >@@ -21,6 +21,7 @@ use Modern::Perl; > > use Test::More tests => 1; > use Test::Mojo; >+use Test::Warn; > > use t::lib::TestBuilder; > use t::lib::Mocks; >@@ -31,6 +32,7 @@ use Array::Utils qw( array_minus ); > use Koha::ERM::EUsage::CounterFiles; > use Koha::Database; > >+my $schema = Koha::Database->new->schema; > my $builder = t::lib::TestBuilder->new; > > my $t = Test::Mojo->new('Koha::REST::V1'); >@@ -42,6 +44,8 @@ t::lib::Mocks::mock_preference( 'RESTBasicAuth', 1 ); > subtest 'get() tests' => sub { > plan tests => 5; > >+ $schema->storage->txn_begin; >+ > my $service_url = "https://registry.countermetrics.org/api/v1/sushi-service/b94bc981-fa16-4bf6-ba5f-6c113f7ffa0b/"; > my @expected_fields = ( > "api_key_info", >@@ -57,6 +61,7 @@ subtest 'get() tests' => sub { > "id", > "ip_address_authorization", > "ip_address_authorization_info", >+ "last_audit", > "migrations", > "notification_count", > "notifications_url", >@@ -99,5 +104,11 @@ subtest 'get() tests' => sub { > my @response_fields = map { $_ } keys %$sushi_service; > my @new_fields_in_response = array_minus( @response_fields, @expected_fields ); > >- is( scalar(@new_fields_in_response), 0, 'The response fields match the expected fields' ); >+ my $new_fields_string = >+ "This is not a new error within Koha, the following new field(s) have been added to the API repsonse: " >+ . join( ', ', @new_fields_in_response ) >+ . '. They should be added to the API definition'; >+ warning_like { scalar(@new_fields_in_response) } 0, $new_fields_string; >+ >+ $schema->storage->txn_rollback; > }; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 39007
:
177381
|
177382
|
177390
|
177392
|
177463
| 178004 |
178005
|
178006