Bugzilla – Attachment 178075 Details for
Bug 38469
Circulation returns vulnerable to reflected XSS
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38469: Replace single quotes with double quotes to prevent XSS
Bug-38469-Replace-single-quotes-with-double-quotes.patch (text/plain), 1.96 KB, created by
Marcel de Rooy
on 2025-02-14 07:39:30 UTC
(
hide
)
Description:
Bug 38469: Replace single quotes with double quotes to prevent XSS
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2025-02-14 07:39:30 UTC
Size:
1.96 KB
patch
obsolete
>From be1a47dd92160cc46b1d922cc4637f073a3f28af Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Mon, 18 Nov 2024 04:46:31 +0000 >Subject: [PATCH] Bug 38469: Replace single quotes with double quotes to > prevent XSS >Content-Type: text/plain; charset=utf-8 > >This change replaces single quotes with double quotes to prevent XSS >for particular operations on the circ returns page. > >Test plan: >0. Apply the patch >1. Go to http://localhost:8081/cgi-bin/koha/circ/returns.pl?print_slip=1&reserve_id=1 >2. Note that a pring slip is generated >(you may need to allow popups) > >3. To test the XSS is patched, try the proof-of-concept from the >bug report > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 39c7500712..618519e9f3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -1515,10 +1515,10 @@ > [% IF reserve_id %] > $(".print-slip").on('click', function(e) { > e.preventDefault(); >- Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]'); >+ Dopop("hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]"); > }); > [% IF print_slip %] >- Dopop('hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]'); >+ Dopop("hold-transfer-slip.pl?reserve_id=[% reserve_id | uri %]"); > [% END %] > [% END %] > var table_settings = [% TablesSettings.GetTableSettings( 'circ', 'returns', 'checkedintable', 'json' ) | $raw %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38469
:
174657
|
175035
|
176058
| 178075