Bugzilla – Attachment 178100 Details for
Bug 38045
Patron messaging preference table says it is loading but never does if fieldset is collapsed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38045: Don't show loading message when hiding messaging preferences
Bug-38045-Dont-show-loading-message-when-hiding-me.patch (text/plain), 1.85 KB, created by
Nick Clemens (kidclamp)
on 2025-02-14 14:53:21 UTC
(
hide
)
Description:
Bug 38045: Don't show loading message when hiding messaging preferences
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-02-14 14:53:21 UTC
Size:
1.85 KB
patch
obsolete
>From a33ee0aa8bd7d62da7407f4b4a519af17098ff29 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 14 Feb 2025 14:49:26 +0000 >Subject: [PATCH] Bug 38045: Don't show loading message when hiding messaging > preferences > >This spinner is meant to show when the category has changed and we are >loading the new defaults for a category. >There is no reason to toggle visibility when the form is initially hidden > >To test: > 1 - Mark 'Patron messaging preference' in CollapseFieldsPatronAddForm > 2 - Edit an existing patron or add a new one > 3 - Note the spinner 'Loading new messaging preferences' > 4 - Click the toggle to hide/show messaging preferences a few times > 5 - Spinner disappears and table can be shown > 6 - Apply patch > 7 - Edit existing or add new patron > 8 - No spinner > 9 - Change patorn category and say yes to laod new prefs >10 - Note spinner shows and then hides very fast > It is easier to see if you collapse all the fields between category and messaing prefs >11 - Confirm messaging prefs can be edited/saved correctly still >--- > .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 621fe2783d0..729cb3ce0ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1765,7 +1765,6 @@ > [% IF Koha.Preference('EnhancedMessagingPreferences') %] > [% IF fieldstohide.grep('^messaging$').size %] > togglePanel( $("#patron_messaging_prefs_lgd") ); >- $("#messaging_prefs_loading").toggle(); > [% END %] > [% END %] > [% END %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38045
: 178100