Bugzilla – Attachment 178101 Details for
Bug 38986
Restore "Any" option to purchase suggestion filter by fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38986: Restore Any option to suggestions homepage filter
Bug-38986-Restore-Any-option-to-suggestions-homepa.patch (text/plain), 2.03 KB, created by
Andrew Fuerste-Henry
on 2025-02-14 14:55:57 UTC
(
hide
)
Description:
Bug 38986: Restore Any option to suggestions homepage filter
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2025-02-14 14:55:57 UTC
Size:
2.03 KB
patch
obsolete
>From 73d4ca6b4f9959022881f19b26303f6ca7f86e0e Mon Sep 17 00:00:00 2001 >From: Andrew Fuerste Henry <andrew@bywatersolutions.com> >Date: Fri, 14 Feb 2025 14:49:51 +0000 >Subject: [PATCH] Bug 38986: Restore Any option to suggestions homepage filter > >"Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" >"None" should show only suggestions with no fund value selected. A new suggestion should default to "None" > >To Test: >1: have two suggestions, one with a fund selected and one without >2: go to suggestions homepage, confirm the filter does not have an "Any" option >3: apply patch, reload page >4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above >5: confirm the fund filter defaults to Any as you change the branch filter >6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any >--- > .../prog/en/modules/suggestion/suggestion.tt | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 9c0a5595b8..1b0931861c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1337,12 +1337,11 @@ > <select name="budgetid" id="budgetid"> > [% UNLESS op == 'save' %] > <option value="">Any</option> >+ [% END %] >+ [% IF budgetid == '__NONE__' %] >+ <option value="__NONE__" selected="selected">None</option> > [% ELSE %] >- [% IF budgetid == '__NONE__' %] >- <option value="__NONE__" selected="selected">None</option> >- [% ELSE %] >- <option value="__NONE__">None</option> >- [% END %] >+ <option value="__NONE__">None</option> > [% END %] > [% FOREACH budget IN sugg_budgets %] > [% IF ( budget.selected ) %] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38986
:
177282
|
177285
|
177473
|
177474
|
177494
|
178101
|
178139