Bugzilla – Attachment 178106 Details for
Bug 36954
SIP server logging: the use of three log files is confusing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36954: Adjust logfiles in koha-sip
Bug-36954-Adjust-logfiles-in-koha-sip.patch (text/plain), 1.95 KB, created by
Nick Clemens (kidclamp)
on 2025-02-14 16:37:36 UTC
(
hide
)
Description:
Bug 36954: Adjust logfiles in koha-sip
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2025-02-14 16:37:36 UTC
Size:
1.95 KB
patch
obsolete
>From a6e4a8c17590322904945c38378736c487bfa95d Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 28 Jan 2025 15:02:32 +0000 >Subject: [PATCH] Bug 36954: Adjust logfiles in koha-sip > >No need for three files here (and badly specified). >We can just use sip.log. > >Test plan: >Run koha-sip and verify that logging is still done as expected. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > debian/scripts/koha-sip | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) > >diff --git a/debian/scripts/koha-sip b/debian/scripts/koha-sip >index 3372e01d953..aca6cac6ba7 100755 >--- a/debian/scripts/koha-sip >+++ b/debian/scripts/koha-sip >@@ -77,9 +77,7 @@ start_sip() > fi > > DAEMONOPTS="--name=${name}-koha-sip \ >- --errlog=/var/log/koha/${name}/sip-error.log \ >- --stdout=/var/log/koha/${name}/sip.log \ >- --output=/var/log/koha/${name}/sip-output.log \ >+ --output=/var/log/koha/${name}/sip.log \ > --verbose=1 \ > --respawn \ > --delay=30 \ >@@ -117,9 +115,7 @@ stop_sip() > if is_sip_running $name; then > > DAEMONOPTS="--name=${name}-koha-sip \ >- --errlog=/var/log/koha/${name}/sip-error.log \ >- --stdout=/var/log/koha/${name}/sip.log \ >- --output=/var/log/koha/${name}/sip-output.log \ >+ --output=/var/log/koha/${name}/sip.log \ > --verbose=1 \ > --respawn \ > --delay=30 \ >@@ -231,9 +227,7 @@ _check_and_fix_perms() > { > local name=$1 > >- local files="/var/log/koha/${name}/sip-error.log \ >- /var/log/koha/${name}/sip.log \ >- /var/log/koha/$name/sip-output.log" >+ local files="/var/log/koha/${name}/sip.log" > > for file in ${files} > do >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36954
:
177315
|
177353
|
177365
| 178106 |
178107
|
178135